Chromium Code Reviews| Index: chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc |
| =================================================================== |
| --- chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc (revision 96178) |
| +++ chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc (working copy) |
| @@ -32,45 +32,45 @@ |
| // A simple pair of fields that identify a set of Google cookies, used to |
| // filter from a larger set. |
| -struct GoogleCookieFilter { |
| - // The generalized, fully qualified URL of pages where |
| - // cookies with id |cookie_id| are obtained / accessed. |
| - const char* url; |
| - // The id of the cookie this filter is selecting, |
| - // with name/value delimiter (i.e '='). |
| - const char* cookie_id; |
| -}; |
| +// struct GoogleCookieFilter { |
|
erikwright (departed)
2011/08/19 18:13:05
I guess we will remove this since it is apparently
Randy Smith (Not in Mondays)
2011/08/19 20:54:08
Have you checked with an OWNER of (or someone who'
erikwright (departed)
2011/09/06 17:34:45
Added as a reviewer on the new CL.
|
| +// // The generalized, fully qualified URL of pages where |
| +// // cookies with id |cookie_id| are obtained / accessed. |
| +// const char* url; |
| +// // The id of the cookie this filter is selecting, |
| +// // with name/value delimiter (i.e '='). |
| +// const char* cookie_id; |
| +// }; |
| -// Filters to select Google GAIA cookies. |
| -static const GoogleCookieFilter kGAIACookieFilters[] = { |
| - { "http://.google.com/", "SID=" }, // Gmail. |
| - // Add filters here for other interesting cookies that should result in |
| - // showing the promotions (e.g ASIDAS for dasher accounts). |
| -}; |
| +// // Filters to select Google GAIA cookies. |
| +// static const GoogleCookieFilter kGAIACookieFilters[] = { |
| +// { "http://.google.com/", "SID=" }, // Gmail. |
| +// // Add filters here for other interesting cookies that should result in |
| +// // showing the promotions (e.g ASIDAS for dasher accounts). |
| +// }; |
| -bool IsGoogleGAIACookieInstalled() { |
| - for (size_t i = 0; i < arraysize(kGAIACookieFilters); ++i) { |
| - // Since we are running on the UI thread don't call GetURLRequestContext(). |
| - net::CookieStore* store = |
| - Profile::Deprecated::GetDefaultRequestContext()-> |
| - DONTUSEME_GetCookieStore(); |
| - GURL url(kGAIACookieFilters[i].url); |
| - net::CookieOptions options; |
| - options.set_include_httponly(); // The SID cookie might be httponly. |
| - std::string cookies = store->GetCookiesWithOptions(url, options); |
| - std::vector<std::string> cookie_list; |
| - base::SplitString(cookies, ';', &cookie_list); |
| - for (std::vector<std::string>::iterator current = cookie_list.begin(); |
| - current != cookie_list.end(); |
| - ++current) { |
| - size_t position = |
| - current->find(kGAIACookieFilters[i].cookie_id); |
| - if (0 == position) |
| - return true; |
| - } |
| - } |
| - return false; |
| -} |
| +// bool IsGoogleGAIACookieInstalled() { |
| +// for (size_t i = 0; i < arraysize(kGAIACookieFilters); ++i) { |
| +// // Since we are running on the UI thread don't call GetURLRequestContext(). |
| +// net::CookieStore* store = |
| +// Profile::Deprecated::GetDefaultRequestContext()-> |
| +// DONTUSEME_GetCookieStore(); |
| +// GURL url(kGAIACookieFilters[i].url); |
| +// net::CookieOptions options; |
| +// options.set_include_httponly(); // The SID cookie might be httponly. |
| +// std::string cookies = store->GetCookiesWithOptions(url, options); |
| +// std::vector<std::string> cookie_list; |
| +// base::SplitString(cookies, ';', &cookie_list); |
| +// for (std::vector<std::string>::iterator current = cookie_list.begin(); |
| +// current != cookie_list.end(); |
| +// ++current) { |
| +// size_t position = |
| +// current->find(kGAIACookieFilters[i].cookie_id); |
| +// if (0 == position) |
| +// return true; |
| +// } |
| +// } |
| +// return false; |
| +// } |
| NewTabPageSyncHandler::NewTabPageSyncHandler() : sync_service_(NULL), |
| waiting_for_initial_page_load_(true) { |