Update (old) harfbuzz to ToT

Update (old) harfbuzz to ToT

This CL is made by:
- Got harfbuzz ToT (revision d10a264823e81631336bab37f08a52cc243d3654)
- Applied third_party/harfbuzz/chromium.patch to harfbuzz ToT.
- Applied the change made by http://codereview.chromium.org/543067/
  (chromium.patch doesn't include this change)
- Copied revised files to third_party/harfbuzz
- Updated README.chromium and chromium.patch

BUG=91789
TEST=ran WebKit layout tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95926

[bashi, 2011-08-08 04:46:06]

Hi,

Files to review: chromium.patch and README.chromium.

[agl, 2011-08-08 14:04:52]

LGTM

[Evan Martin, 2011-08-08 14:57:05]

LGTM either way, but I'm a little worried that chromium.patch was out
of date in other ways.

On Sun, Aug 7, 2011 at 9:46 PM,  <bashi@chromium.org> wrote:
> This CL is made by:
> - Got harfbuzz ToT (revision d10a264823e81631336bab37f08a52cc243d3654)

You could right here reconstruct chromium.patch by doing a diff
between the harfbuzz revision mentioned in README.chromium and the
harfbuzz code in our tree.  Then you could skip the step below where
you manually reapply a patch from a code review.  (You can actually do
all of this with git if you want to be fancy about it...)

> - Applied third_party/harfbuzz/chromium.patch to harfbuzz ToT.
> - Applied the change made by http://codereview.chromium.org/543067/
>  (chromium.patch doesn't include this change)
> - Copied revised files to third_party/harfbuzz
> - Updated README.chromium and chromium.patch

[bashi, 2011-08-08 23:50:14]

Hi Evan,

Thank you for review.  I might misunderstand your comments, but there are
unnecessarily files in harfbuzz directory and I don't want to include them in
the chromium.patch.  I'll submit this CL either way, but I'll revise
chromium.patch if there is more appropriate way to reconstruct it.

On 2011/08/08 14:57:05, Evan Martin wrote:
> LGTM either way, but I'm a little worried that chromium.patch was out
> of date in other ways.
> 
> On Sun, Aug 7, 2011 at 9:46 PM,  <mailto:bashi@chromium.org> wrote:
> > This CL is made by:
> > - Got harfbuzz ToT (revision d10a264823e81631336bab37f08a52cc243d3654)
> 
> You could right here reconstruct chromium.patch by doing a diff
> between the harfbuzz revision mentioned in README.chromium and the
> harfbuzz code in our tree.  Then you could skip the step below where
> you manually reapply a patch from a code review.  (You can actually do
> all of this with git if you want to be fancy about it...)
> 
> > - Applied third_party/harfbuzz/chromium.patch to harfbuzz ToT.
> > - Applied the change made by http://codereview.chromium.org/543067/
> > &nbsp;(chromium.patch doesn't include this change)
> > - Copied revised files to third_party/harfbuzz
> > - Updated README.chromium and chromium.patch