ntp4: most visited dragging onto apps page

chrome/browser/resources/ntp4/apps_page.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp4', function() {
   'use strict';
 
   var localStrings = new LocalStrings;
 
   var APP_LAUNCH = {
@@ skipping 309 matching lines @@
      * Returns a pointer to the context menu for this app. All apps share the
      * singleton AppContextMenu. This function is called by the
      * ContextMenuHandler in response to the 'contextmenu' event.
      * @type {cr.ui.Menu}
      */
     get contextMenu() {
       var menu = AppContextMenu.getInstance();
       menu.setupForApp(this);
       return menu.menu;
     },
+
+    /**
+     * Returns whether this element can be 'removed' from chrome (i.e. whether
+     * the user can drag it onto the trash and expect something to happen).
+     * @return {boolean} True if the app can be uninstalled.
+     */
+    canBeRemoved: function() {
+      return this.appData_.can_uninstall;
+    },
+
+    /**
+     * Uninstalls the app after it's been dropped on the trash.
+     * @return {boolean} True if the app can be uninstalled.

[Rick Byers, 2011/08/08 15:24:15]

Remove - doesn't return anything

[Evan Stade, 2011/08/08 18:26:58]

Done.

+     */
+    removeFromChrome: function() {
+      chrome.send('uninstallApp', [this.appData_.id, true]);
+
+      var tile = this.parentNode;
+      tile.tilePage.cleanupDrag();
+      tile.parentNode.removeChild(tile);
+    },
   };
 
   var TilePage = ntp4.TilePage;
 
   // The fraction of the app tile size that the icon uses.
   var APP_IMG_SIZE_FRACTION = 4 / 5;
 
   var appsPageGridValues = {
     // The fewest tiles we will show in a row.
     minColCount: 3,
@@ skipping 37 matching lines @@
       this.appendTile(new App(appData), animate);
     },
 
     /** @inheritDoc */
     shouldAcceptDrag: function(e) {
       return ntp4.getCurrentlyDraggingTile() ||
           (e.dataTransfer && e.dataTransfer.types.indexOf('url') != -1);
     },
 
     /** @inheritDoc */
-    addOutsideData: function(dataTransfer, index) {
+    addDragData: function(dataTransfer, index) {
+      var currentlyDraggingTile = ntp4.getCurrentlyDraggingTile();
+      if (currentlyDraggingTile) {
+        var tileContents = currentlyDraggingTile.firstChild;
+        if (tileContents.classList.contains('app')) {
+          this.tileGrid_.insertBefore(
+              currentlyDraggingTile,
+              this.tileElements_[index]);
+          this.tileMoved(currentlyDraggingTile);
+        } else if (tileContents.classList.contains('most-visited')) {
+          this.generateAppForLink(tileContents.data);
+        }
+      } else {
+        this.addOutsideData_(e.dataTransfer, index);
+      }
+    },
+
+    /**
+     * Adds drag data that has been dropped from a source that is not a tile.
+     * @param {Object} dataTransfer The data transfer object that holds drop
+     *     data.
+     * @param {number} index The index for the new data.
+     * @private
+     */
+    addOutsideData_: function(dataTransfer, index) {
       var url = dataTransfer.getData('url');
       assert(url);
       if (!url)
         return;
 
       // If the dataTransfer has html data, use that html's text contents as the
       // title of the new link.
       var html = dataTransfer.getData('text/html');
       var title;
       if (html) {
@@ skipping 12 matching lines @@
       if (data.title.length > 45)
         data.title = data.title.substring(0,45);
       if (data.title.length == 0)
         data.title = data.url;
       this.generateAppForLink(data);
     },
 
     /**
      * Creates a new crx-less app manifest and installs it.
      * @param {Object} data The data object describing the link. Must have |url|
-     * and |title| members.
+     *     and |title| members.
+     * TODO(estade): pass along an index.
      */
     generateAppForLink: function(data) {
+      assert(data.url != undefined);
+      assert(data.title != undefined);
       chrome.send('generateAppForLink', [data.url, data.title]);
     },
 
     /** @inheritDoc */
     tileMoved: function(draggedTile) {
       if (!(draggedTile.firstChild instanceof App))
         return;
 
       var pageIndex = ntp4.getAppsPageIndex(this);
       chrome.send('setPageIndex', [draggedTile.firstChild.appId, pageIndex]);
@@ skipping 13 matching lines @@
     var store = document.querySelector('.webstore');
     if (store)
       store.setAppsPromoData(data);
   };
 
   return {
     APP_LAUNCH: APP_LAUNCH,
     AppsPage: AppsPage,
   };
 });