Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: webkit/glue/media/buffered_resource_loader.h

Issue 7591001: Log BufferedResourceLoader events to MediaLog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/media/buffered_resource_loader.h
diff --git a/webkit/glue/media/buffered_resource_loader.h b/webkit/glue/media/buffered_resource_loader.h
index bdbb6a885ab90fcbd2b40d4de712afa2c541d9af..94098d15b28d81b15b0d0f3d1240511ed52c6004 100644
--- a/webkit/glue/media/buffered_resource_loader.h
+++ b/webkit/glue/media/buffered_resource_loader.h
@@ -20,6 +20,10 @@
#include "webkit/glue/media/web_data_source.h"
#include "webkit/glue/webmediaplayer_impl.h"
+namespace media {
+class MediaLog;
+}
+
namespace webkit_glue {
const int64 kPositionNotSpecified = -1;
@@ -54,7 +58,8 @@ class BufferedResourceLoader
// |kPositionNotSpecified| for not specified.
BufferedResourceLoader(const GURL& url,
int64 first_byte_position,
- int64 last_byte_position);
+ int64 last_byte_position,
+ media::MediaLog* media_log);
// Start the resource loading with the specified URL and range.
// This method operates in asynchronous mode. Once there's a response from the
@@ -211,6 +216,9 @@ class BufferedResourceLoader
// Helper function that returns true if a range request was specified.
bool IsRangeRequest() const;
+ // Log everything interesting to media_log_.
scherkus (not reviewing) 2011/08/08 23:18:25 || around params
Scott Franklin 2011/08/09 00:27:27 Done.
+ void Log();
+
// A sliding window of buffer.
scoped_ptr<media::SeekableBuffer> buffer_;
@@ -264,6 +272,8 @@ class BufferedResourceLoader
// Used to ensure mocks for unittests are used instead of reset in Start().
bool keep_test_loader_;
+ scoped_refptr<media::MediaLog> media_log_;
+
DISALLOW_COPY_AND_ASSIGN(BufferedResourceLoader);
};

Powered by Google App Engine
This is Rietveld 408576698