Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 7590009: Merge 92255 - Source/WebCore: [Chromium] Use edge-distance method for layer anti-aliasing. (Closed)

Created:
9 years, 4 months ago by Vangelis Kokkevis
Modified:
9 years, 4 months ago
Reviewers:
jamesr1
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 92255 - Source/WebCore: [Chromium] Use edge-distance method for layer anti-aliasing. https://bugs.webkit.org/show_bug.cgi?id=64942 Patch by David Reveman <reveman@chromium.org>; on 2011-08-02 Reviewed by James Robinson. Use an edge distance based method instead of the current linear filtering method for producing anti-aliased edges on 3D transformed layers. This removes the outer border handling from TilingData as it's no longer needed for anti-aliasing. Tests: platform/chromium/compositing/tiny-layer-rotated.html (existing) platform/chromium/compositing/huge-layer-rotated.html (existing) compositing/images/content-image-change.html (existing) TilingDataTest in webkit_unit_tests * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::screenMatrix): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::setDrawViewportRect): (WebCore::LayerRendererChromium::tilerProgramAA): (WebCore::LayerRendererChromium::tilerProgramSwizzleAA): * platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::windowMatrix): * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::tileLayerRect): (WebCore::LayerTilerChromium::invalidateRect): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::growLayerToContain): (WebCore::LayerTilerChromium::drawTiles): * platform/graphics/chromium/LayerTilerChromium.h: * platform/graphics/chromium/ShaderChromium.cpp: (WebCore::VertexShaderTile::VertexShaderTile): (WebCore::VertexShaderTile::init): (WebCore::VertexShaderTile::getShaderString): (WebCore::FragmentTexAlphaAABinding::FragmentTexAlphaAABinding): (WebCore::FragmentTexAlphaAABinding::init): (WebCore::FragmentShaderRGBATexAlphaAA::getShaderString): (WebCore::FragmentShaderRGBATexSwizzleAlphaAA::getShaderString): * platform/graphics/chromium/ShaderChromium.h: (WebCore::VertexShaderTile::vertexTexTransformLocation): (WebCore::FragmentTexAlphaAABinding::alphaLocation): (WebCore::FragmentTexAlphaAABinding::samplerLocation): (WebCore::FragmentTexAlphaAABinding::fragmentTexTransformLocation): (WebCore::FragmentTexAlphaAABinding::edgeLocation): * platform/graphics/chromium/TiledLayerChromium.cpp: (WebCore::TiledLayerChromium::TiledLayerChromium): (WebCore::TiledLayerChromium::updateTileSizeAndTilingOption): (WebCore::TiledLayerChromium::createTilerIfNeeded): (WebCore::TiledLayerChromium::setIsMask): * platform/graphics/chromium/TiledLayerChromium.h: * platform/graphics/gpu/TilingData.cpp: (WebCore::computeNumTiles): (WebCore::TilingData::tileXIndexFromSrcCoord): (WebCore::TilingData::tileYIndexFromSrcCoord): (WebCore::TilingData::tileSizeX): (WebCore::TilingData::tileSizeY): (WebCore::TilingData::intersectDrawQuad): (WebCore::TilingData::textureOffset): * platform/graphics/gpu/TilingData.h: Source/WebKit/chromium: [Chromium] Remove outer border from TilingData as it's no longer needed by layer compositor for anti-aliasing. https://bugs.webkit.org/show_bug.cgi?id=64942 Patch by David Reveman <reveman@chromium.org>; on 2011-08-02 Reviewed by James Robinson. * tests/TilingDataTest.cpp: (WebCore::TEST): LayoutTests: [Chromium] Use edge-distance method for layer anti-aliasing. https://bugs.webkit.org/show_bug.cgi?id=64942 Patch by David Reveman <reveman@chromium.org>; on 2011-08-02 Reviewed by James Robinson. Update expected results. * platform/chromium/test_expectations.txt: TBR=jamesr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -297 lines) Patch
M LayoutTests/platform/chromium/test_expectations.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h View 4 chunks +6 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp View 4 chunks +39 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/LayerTilerChromium.h View 3 chunks +7 lines, -11 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp View 13 chunks +142 lines, -115 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/ShaderChromium.h View 2 chunks +32 lines, -4 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/ShaderChromium.cpp View 3 chunks +72 lines, -8 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/TiledLayerChromium.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp View 6 chunks +4 lines, -7 lines 0 comments Download
M Source/WebCore/platform/graphics/gpu/TilingData.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/gpu/TilingData.cpp View 8 chunks +15 lines, -20 lines 0 comments Download
M Source/WebKit/chromium/tests/TilingDataTest.cpp View 12 chunks +129 lines, -129 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Vangelis Kokkevis
9 years, 4 months ago (2011-08-09 22:19:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698