Sync performance tests: take timings with autofill keys in addition to profiles.

Sync performance tests: take timings with autofill keys in addition to profiles.

This patch extends the existing AutofillSyncPerfTest class to also measure add and
delete time for autofill keys.  Updating an individual autofill key is not possible,
as far as I can tell.

BUG=none
TEST=sync_performance_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96304

[Raghu Simha, 2011-08-10 19:43:38]

LGTM pending a few minor fixes.

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
File chrome/test/live_sync/performance/autofill_sync_perf_test.cc (right):

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:46: // Removes all
autofill profiles for |profile|.
nit: s/for/from/

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:52: // Removes all
autofill keys for |profile|.
nit: s/for/from/

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:120: void
AutofillSyncPerfTest::AddKeys(int profile, int num_profiles) {
s/num_profiles/num_keys/

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:124: };
Remove semicolon.

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:128: void
AutofillSyncPerfTest::RemoveKeys(int profile) {
Perhaps name this RemoveAllKeys, since that's what it's doing?

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:202:
IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, Autofill_P0) {
Perhaps name this test AutofillKeys_P0?

[braffert, 2011-08-10 19:52:35]

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
File chrome/test/live_sync/performance/autofill_sync_perf_test.cc (right):

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:46: // Removes all
autofill profiles for |profile|.
On 2011/08/10 19:43:38, rsimha wrote:
> nit: s/for/from/

Done.

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:52: // Removes all
autofill keys for |profile|.
On 2011/08/10 19:43:38, rsimha wrote:
> nit: s/for/from/

Done.

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:120: void
AutofillSyncPerfTest::AddKeys(int profile, int num_profiles) {
On 2011/08/10 19:43:38, rsimha wrote:
> s/num_profiles/num_keys/

Done.

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:124: };
On 2011/08/10 19:43:38, rsimha wrote:
> Remove semicolon.

Done.  Don't know how that got in there.

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:128: void
AutofillSyncPerfTest::RemoveKeys(int profile) {
On 2011/08/10 19:43:38, rsimha wrote:
> Perhaps name this RemoveAllKeys, since that's what it's doing?

This is a good suggestion, but I will leave it as is for now so that it matches
the pattern established by the other datatypes.  Any change should be made
across the board (RemoveAllBookmarks, UpdateAllExtensions ...)

http://codereview.chromium.org/7590007/diff/2002/chrome/test/live_sync/perfor...
chrome/test/live_sync/performance/autofill_sync_perf_test.cc:202:
IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, Autofill_P0) {
On 2011/08/10 19:43:38, rsimha wrote:
> Perhaps name this test AutofillKeys_P0?

Anna suggested using only Autofill as the name here - I believe so that it
matches the naming used in TCM.

[commit-bot: I haz the power, 2011-08-10 23:34:45]

Try job failure for 7590007-9001 (retry) on linux for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&numb...

[commit-bot: I haz the power, 2011-08-11 02:21:28]

Change committed as 96304