Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: chrome/browser/translate/translate_infobar_delegate.h

Issue 7589002: Fix a crash in the translate info bar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_infobar_delegate.h
===================================================================
--- chrome/browser/translate/translate_infobar_delegate.h (revision 95783)
+++ chrome/browser/translate/translate_infobar_delegate.h (working copy)
@@ -39,8 +39,8 @@
// Factory method to create a non-error translate infobar.
// The original and target language specified are the ASCII language codes
// (ex: en, fr...).
- // Returns NULL if it failed, typically if |original_language| or
- // |target_language| is not a supported language.
+ // CHECK if |original_language| or |target_language| is not a supported
+ // language, though |original_language| can be unknown if type is TRANSLATING.
static TranslateInfoBarDelegate* CreateDelegate(
Type infobar_type,
TabContents* tab_contents,

Powered by Google App Engine
This is Rietveld 408576698