Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 7587019: Suppressed slow OriginBoundCertServiceTest.* tests, one of which was timing out on TSAN. (Closed)

Created:
9 years, 4 months ago by rkn
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Suppressed slow OriginBoundCertServiceTest.* tests, one of which was timing out on TSAN. BUG=92439 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96320

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/net_unittests.gtest-tsan.txt View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
rkn
thestig: Please review.
9 years, 4 months ago (2011-08-11 01:17:50 UTC) #1
Lei Zhang
LGTM stamp
9 years, 4 months ago (2011-08-11 01:20:09 UTC) #2
wtc
LGTM. http://codereview.chromium.org/7587019/diff/1/tools/valgrind/gtest_exclude/net_unittests.gtest-tsan.txt File tools/valgrind/gtest_exclude/net_unittests.gtest-tsan.txt (right): http://codereview.chromium.org/7587019/diff/1/tools/valgrind/gtest_exclude/net_unittests.gtest-tsan.txt#newcode28 tools/valgrind/gtest_exclude/net_unittests.gtest-tsan.txt:28: OriginBoundCertServiceTest.* Do we need to suppress all OriginBoundCertServiceTest.* ...
9 years, 4 months ago (2011-08-11 01:50:13 UTC) #3
rkn
http://codereview.chromium.org/7587019/diff/1/tools/valgrind/gtest_exclude/net_unittests.gtest-tsan.txt File tools/valgrind/gtest_exclude/net_unittests.gtest-tsan.txt (right): http://codereview.chromium.org/7587019/diff/1/tools/valgrind/gtest_exclude/net_unittests.gtest-tsan.txt#newcode28 tools/valgrind/gtest_exclude/net_unittests.gtest-tsan.txt:28: OriginBoundCertServiceTest.* On 2011/08/11 01:50:13, wtc wrote: > Do we ...
9 years, 4 months ago (2011-08-11 01:59:34 UTC) #4
commit-bot: I haz the power
Change committed as 96320
9 years, 4 months ago (2011-08-11 04:04:27 UTC) #5
Alexander Potapenko
9 years, 3 months ago (2011-08-29 09:42:57 UTC) #6
Just to be more pedantic, we usually suppress the error reports, not the tests.
Tests are disabled or filtered out.

Powered by Google App Engine
This is Rietveld 408576698