Remove mock_ffmpeg and update media unittests.

media/base/test_data_util.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BASE_TEST_DATA_UTIL_H_
+#define MEDIA_BASE_TEST_DATA_UTIL_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/scoped_ptr.h"
+#include "media/base/data_buffer.h"
+
+namespace media {
+
+bool ReadTestDataFile(const std::string& name,

[scherkus (not reviewing), 2011/08/11 01:26:29]

docs

[acolwell GONE FROM CHROMIUM, 2011/08/11 23:54:40]

Done.

+                      scoped_array<uint8>* buffer,

[scherkus (not reviewing), 2011/08/11 01:26:29]

is the scoped_array out ptr intended to be a helpful reminder to free the
memory?

[acolwell GONE FROM CHROMIUM, 2011/08/11 23:54:40]

yes

+                      int* size);
+
+bool ReadTestDataFile(const std::string& name, scoped_refptr<Buffer>* buffer);

[scherkus (not reviewing), 2011/08/11 01:26:29]

I notice that everyone EXPECT_TRUEs these functions

would we ever have a case where we expect a file not to load?

can these be voids with CHECKs instead?  It seems that if a file can't load,
then most/all of the tests can't run

[acolwell GONE FROM CHROMIUM, 2011/08/11 23:54:40]

Done.

+
+}  // namespace media
+
+#endif  // MEDIA_BASE_TEST_DATA_UTIL_H_