Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 7587008: Adding traces to OmxVideoDecodeAccelerator (Closed)

Created:
9 years, 4 months ago by piman
Modified:
9 years, 4 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Adding traces to OmxVideoDecodeAccelerator BUG=None TEST=about:tracing with GLES2 on ARM. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96333

Patch Set 1 #

Patch Set 2 : more traces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M content/common/gpu/media/omx_video_decode_accelerator.cc View 1 9 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
piman
9 years, 4 months ago (2011-08-10 23:04:17 UTC) #1
Ami GONE FROM CHROMIUM
LGTM as far as it goes but I'm curious how you chose what to instrument. ...
9 years, 4 months ago (2011-08-10 23:54:18 UTC) #2
piman
On 2011/08/10 23:54:18, Ami Fischman wrote: > LGTM as far as it goes but I'm ...
9 years, 4 months ago (2011-08-11 04:33:35 UTC) #3
Ami GONE FROM CHROMIUM
LGTM thanks!
9 years, 4 months ago (2011-08-11 04:38:43 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-11 06:48:02 UTC) #5
Change committed as 96333

Powered by Google App Engine
This is Rietveld 408576698