Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Unified Diff: media/base/media_log.h

Issue 7587007: Log FilterHost events in PipelineImpl to MediaLog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/media_log.cc » ('j') | media/base/media_log_event.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media_log.h
diff --git a/media/base/media_log.h b/media/base/media_log.h
index c9905e5429afeede5784c04ee73bb6aa1d499879..3a300e2d8ad2e6031294d3f25a0dcd918ccaac6e 100644
--- a/media/base/media_log.h
+++ b/media/base/media_log.h
@@ -9,6 +9,7 @@
#include "base/memory/ref_counted.h"
#include "media/base/media_log_event.h"
#include "media/base/pipeline_impl.h"
+#include "media/base/pipeline_status.h"
namespace media {
@@ -17,6 +18,7 @@ class MediaLog : public base::RefCountedThreadSafe<MediaLog> {
// Convert various enums to strings.
static const char* EventTypeToString(MediaLogEvent::Type type);
static const char* PipelineStateToString(PipelineImpl::State);
+ static const char* PipelineStatusToString(PipelineStatus);
MediaLog();
@@ -27,9 +29,17 @@ class MediaLog : public base::RefCountedThreadSafe<MediaLog> {
// Helper methods to create events and their parameters.
MediaLogEvent* CreateEvent(MediaLogEvent::Type type);
+ MediaLogEvent* CreateBooleanEvent(MediaLogEvent::Type type,
+ const char* property, bool value);
+ MediaLogEvent* CreateIntegerEvent(MediaLogEvent::Type type,
+ const char* property, int64 value);
+ MediaLogEvent* CreateTimeEvent(MediaLogEvent::Type type,
+ const char* property, base::TimeDelta value);
MediaLogEvent* CreateLoadEvent(const std::string& url);
MediaLogEvent* CreateSeekEvent(float seconds);
MediaLogEvent* CreatePipelineStateChangedEvent(PipelineImpl::State state);
+ MediaLogEvent* CreatePipelineErrorEvent(PipelineStatus error);
+ MediaLogEvent* CreateVideoSizeSetEvent(size_t width, size_t height);
MediaLogEvent* CreateBufferedExtentsChangedEvent(size_t start, size_t current,
size_t end);
« no previous file with comments | « no previous file | media/base/media_log.cc » ('j') | media/base/media_log_event.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698