src/SConscript - Issue 7586001: Fixed a known issue in D8 (read file), enabled D8 shared library build on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/SConscript

Issue 7586001: Fixed a known issue in D8 (read file), enabled D8 shared library build on Windows. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fixed the mess where d8 was getting the BUILDING_V8_SHARED compile flag. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/SConscript

diff --git a/src/SConscript b/src/SConscript

index 080ed091037f300205d3aa157a4c1962a2b2b6c5..453a7c6a76e38dc45e7b1f0c49ce0da71155e7a9 100755

--- a/src/SConscript

+++ b/src/SConscript

@@ -32,6 +32,7 @@ sys.path.append(join(root_dir, 'tools'))

import js2c

Import('context')

Import('tools')

+Import('d8_env')

SOURCES = {

@@ -340,7 +341,7 @@ def ConfigureObjectFiles():

else:

d8_files = context.GetRelevantSources(D8_FULL_FILES)

d8_objs = [d8_js_obj]

- d8_objs.append(context.ConfigureObject(env, [d8_files]))

+ d8_objs.append(context.ConfigureObject(d8_env, [d8_files]))

# Combine the JavaScript library files into a single C++ file and

# compile it.

« no previous file with comments | « include/v8.h ('k') | src/d8.h » ('j') | no next file with comments »