Fixed a known issue in D8 (read file), enabled D8 shared library build on Windows.

Fixed a known issue in D8 (read file), enabled D8 shared library build on Windows.

Committed: http://code.google.com/p/v8/source/detail?r=8853

[Yang, 2011-08-05 16:14:12]

PTAL.

http://codereview.chromium.org/7586001/diff/1/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/7586001/diff/1/include/v8.h#newcode3609
include/v8.h:3609: static bool IsActive();
Moving the implementation to v8threads.cc seems to make Visual Studio linker
stop complaining when building with shared library. I don't know why exactly.

http://codereview.chromium.org/7586001/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7586001/diff/1/src/d8.cc#newcode804
src/d8.cc:804: }
Mostly copied from v8::internal::OS::FOpen, but for the sake of being able to
build it with shared lib, a little bit duplicate code.

http://codereview.chromium.org/7586001/diff/1/src/d8.cc#newcode999
src/d8.cc:999: Handle<String> result = String::New(chars, size);
Saved duplicate code.

http://codereview.chromium.org/7586001/diff/1/src/d8.cc#newcode1161
src/d8.cc:1161: delete[] files;
Memory leak.

[Jakob Kummerow, 2011-08-05 17:15:45]

LGTM. 
Please make sure you test this on all platforms with both shared and static
library builds.

http://codereview.chromium.org/7586001/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7586001/diff/1/src/d8.cc#newcode29
src/d8.cc:29: #if (defined(USING_V8_SHARED) || defined(BUILDING_V8_SHARED))
I guess you could avoid all the renaming and still get a catch-all solution if
you just did this:
#if (defined(BUILDING_V8_SHARED) || defined(V8_SHARED))
#define USING_V8_SHARED
#endif
I'm not sure if that would be better. If you've tested the current approach and
it works on all OSs, fine by me.

http://codereview.chromium.org/7586001/diff/1/src/d8.cc#newcode63
src/d8.cc:63: #ifndef ASSERT
you sure about this?

[Yang, 2011-08-08 09:30:01]

I just figured out what the issue was.

On Windows, when building v8 lib, BUILDING_V8_SHARED should be set. For
everything that's linking against v8 lib, USING_V8_SHARED should be set. The
latter was not the case for D8 because of a bug in scons script. That's been
fixed now.

Also, I tested it on all platforms I was able to lay my hands on.

[Jakob Kummerow, 2011-08-08 09:33:50]

Still LGTM.