First CL for the about:policy page. This only implements the policy section of the page.

chrome/browser/ui/webui/policy_ui.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBUI_POLICY_UI_H_
+#define  CHROME_BROWSER_UI_WEBUI_POLICY_UI_H_

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

excess space

[simo, 2011/08/10 14:28:19]

Done.

+#pragma once
+
+#include "base/scoped_ptr.h"
+#include "base/values.h"
+#include "chrome/browser/policy/configuration_policy_reader.h"
+#include "chrome/browser/ui/webui/chrome_web_ui.h"
+#include "content/common/notification_observer.h"
+

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

onlye one newline.

[simo, 2011/08/10 14:28:19]

Done.

+
+// The base class handler of Javascript messages of the about:policy page

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

Missing period.

[simo, 2011/08/10 14:28:19]

Done.

+class PolicyUIHandler : public WebUIMessageHandler,
+                        public NotificationObserver {
+

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

no newline here

[simo, 2011/08/10 14:28:19]

Done.

+  public:

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

indentation

[simo, 2011/08/10 14:28:19]

Done.

+    PolicyUIHandler();
+    virtual ~PolicyUIHandler();
+
+    // WebUIMessageHandler implementation.
+    virtual WebUIMessageHandler* Attach(WebUI* web_ui);
+    virtual void RegisterMessages();
+
+    // Callback for the "requestPolicyData" message.

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

You should make this private, unless you have a good reason to keep it public.

[simo, 2011/08/10 14:28:19]

Done.

+    void HandleRequestPolicyData(const ListValue* args);
+
+    // NotificationObserver implementation.
+    virtual void Observe(int type,
+                         const NotificationSource& source,
+                         const NotificationDetails& details);

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

Here, and on all other overriden functions: add an OVERRIDE declaration before
the ; (see base/compiler_specific.h for the declaration).

[simo, 2011/08/10 14:28:19]

Done.

+  private:
+    scoped_ptr<policy::PolicyStatus> policy_status_;
+    DISALLOW_COPY_AND_ASSIGN(PolicyUIHandler);
+};
+

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

Missing class description

[simo, 2011/08/10 14:28:19]

Done.

+class PolicyUI : public ChromeWebUI {
+  public:

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

indentation

[simo, 2011/08/10 14:28:19]

Done.

+    explicit PolicyUI(TabContents* contents);
+    virtual ~PolicyUI();
+
+  private:
+    DISALLOW_COPY_AND_ASSIGN(PolicyUI);
+};
+
+#endif  // CHROME_BROWSER_UI_WEBUI_POLICY_UI_H_