First CL for the about:policy page. This only implements the policy section of the page.

chrome/browser/ui/webui/policy_ui.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/policy/configuration_policy_reader.h"
+
+#include <string>
+
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/webui/policy_ui.h"
+#include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
+#include "chrome/common/url_constants.h"
+#include "content/common/notification_registrar.h"
+#include "content/browser/tab_contents/tab_contents.h"

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

alphabetize

[simo, 2011/08/10 14:28:19]

Done.

+#include "grit/browser_resources.h"
+#include "grit/generated_resources.h"
+
+ChromeWebUIDataSource* CreatePolicyUIHTMLSource() {
+  ChromeWebUIDataSource* source =
+      new ChromeWebUIDataSource(chrome::kChromeUIPolicyHost);
+
+  // Localized strings.
+  source->AddLocalizedString("policyTitle", IDS_POLICY_TITLE);
+  source->AddLocalizedString("aboutPolicyDescription", IDS_POLICY_DESCRIPTION);
+  source->AddLocalizedString("statusPaneTitle", IDS_POLICY_STATUS_TITLE);
+  source->AddLocalizedString("fetchPoliciesText", IDS_POLICY_FETCH);
+  source->AddLocalizedString("devicePoliciesBoxTitle",
+                             IDS_POLICY_DEVICE_POLICIES);
+  source->AddLocalizedString("userPoliciesBoxTitle",
+                             IDS_POLICY_USER_POLICIES);
+  source->AddLocalizedString("enrollmentDomainText",
+                             IDS_POLICY_ENROLLMENT_DOMAIN);
+  source->AddLocalizedString("lastFetchedText", IDS_POLICY_LAST_FETCHED);
+  source->AddLocalizedString("fetchIntervalText", IDS_POLICY_FETCH_INTERVAL);
+  source->AddLocalizedString("serverStatusText", IDS_POLICY_SERVER_STATUS);
+  source->AddLocalizedString("showUnsentPoliciesText",
+                             IDS_POLICY_SHOW_UNSENT);
+  source->AddLocalizedString("filterPoliciesText", IDS_POLICY_FILTER);
+  source->AddLocalizedString("appliesToTableHeader", IDS_POLICY_APPLIES_TO);
+  source->AddLocalizedString("policyLevelTableHeader", IDS_POLICY_LEVEL);
+  source->AddLocalizedString("policyNameTableHeader", IDS_POLICY_ENTRY_NAME);
+  source->AddLocalizedString("policyValueTableHeader", IDS_POLICY_ENTRY_VALUE);
+  source->AddLocalizedString("policyStatusTableHeader",
+                             IDS_POLICY_ENTRY_STATUS);
+  source->set_json_path("strings.js");
+
+  // Add required resources.
+  source->add_resource_path("policy.css", IDR_POLICY_CSS);
+  source->add_resource_path("policy.js", IDR_POLICY_JS);
+  source->set_default_resource(IDR_POLICY_HTML);
+
+  return source;
+}
+
+////////////////////////////////////////////////////////////////////////////////
+//
+// PolicyUIHandler
+//
+////////////////////////////////////////////////////////////////////////////////
+
+

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

only one newline

[simo, 2011/08/10 14:28:19]

Done.

+PolicyUIHandler::PolicyUIHandler() {
+  policy_status_.reset(new policy::PolicyStatus());
+}
+
+PolicyUIHandler::~PolicyUIHandler() {
+}
+
+WebUIMessageHandler* PolicyUIHandler::Attach(WebUI* web_ui) {
+  return WebUIMessageHandler::Attach(web_ui);
+}
+
+void PolicyUIHandler::RegisterMessages() {
+  web_ui_->RegisterMessageCallback("requestPolicyData",
+    NewCallback(this, &PolicyUIHandler::HandleRequestPolicyData));

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

4 spaces indentation.

[simo, 2011/08/10 14:28:19]

Done.

+}
+
+void PolicyUIHandler::HandleRequestPolicyData(const ListValue* args) {
+  ListValue* list = new ListValue();

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

You are creating a new ListValue object and leak it by reassigning your pointer
3 lines below.

[simo, 2011/08/10 14:28:19]

Done.

+ // policy::PolicyStatus* policy_status = new policy::PolicyStatus();

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

indentation

[simo, 2011/08/10 14:28:19]

Done.

+  list = policy_status_->GetPolicyStatusList();
+  DictionaryValue results;
+  results.Set("policies", list);
+  web_ui_->CallJavascriptFunction("returnPolicyData", results);
+}
+
+void PolicyUIHandler::Observe(int type,

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

Since you have a reference to your PolicyStatus instance to get the data from, I
think you shouldn't use NotificationService here, since you can register an
observer directly. Or even simpler, have PolicyStatus accept a delegate pointer
at construction time that PolicyUIHandler can implement to receive change
notifications.

+                              const NotificationSource& source,
+                              const NotificationDetails& details) {
+  // TODO(simo) set up PolicyStatus as a source and create notifications.
+}
+
+////////////////////////////////////////////////////////////////////////////////
+//
+// PolicyUI
+//
+////////////////////////////////////////////////////////////////////////////////
+
+PolicyUI::PolicyUI(TabContents* contents) : ChromeWebUI(contents) {
+  AddMessageHandler((new PolicyUIHandler)->Attach(this));
+
+  // Set up the chrome://policy/ source.
+  Profile* profile = Profile::FromBrowserContext(contents->browser_context());
+  profile->GetChromeURLDataManager()->AddDataSource(CreatePolicyUIHTMLSource());
+}
+
+PolicyUI::~PolicyUI() {
+}
+

[Mattias Nissler (ping if slow), 2011/08/09 13:20:40]

remove trailing whitespace.

[simo, 2011/08/10 14:28:19]

Done.

+
+
+