Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 7585035: Propagate unknown --tool_flags to Dr. Memory as we do for Valgrind (Closed)

Created:
9 years, 4 months ago by Timur Iskhodzhanov
Modified:
9 years, 4 months ago
Reviewers:
Derek Bruening
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Propagate unknown --tool_flags to Dr. Memory as we do for Valgrind Fix a typo in the prev patch Increase the number of stacktrace frames to 40 TBR=bruening Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95810

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M tools/valgrind/valgrind_test.py View 3 chunks +7 lines, -10 lines 3 comments Download

Messages

Total messages: 1 (0 generated)
Timur Iskhodzhanov
9 years, 4 months ago (2011-08-08 13:38:03 UTC) #1
TBR

http://codereview.chromium.org/7585035/diff/1/tools/valgrind/valgrind_test.py
File tools/valgrind/valgrind_test.py (left):

http://codereview.chromium.org/7585035/diff/1/tools/valgrind/valgrind_test.py...
tools/valgrind/valgrind_test.py:715: parser._parser.add_option("", "--indirect",
action="store_true",
oops - this was copy-paste mistake

http://codereview.chromium.org/7585035/diff/1/tools/valgrind/valgrind_test.py...
tools/valgrind/valgrind_test.py:723: # args that are passed through to Dr.
Memory, but the
This is what --tool_flags was made for.
I've just forgotten to propagate it in the Dr. Memory runner

http://codereview.chromium.org/7585035/diff/1/tools/valgrind/valgrind_test.py...
tools/valgrind/valgrind_test.py:727: # through to valgrind_test.py so we don't
need to use --tool_flags
re: to use --tool_flags or not to use
If one makes a typo in some chrome_tests flag (e.g. --t0ol), the suggested
approach would propagate --t0ol to the tool and it would fail on load. This is
not very debuggable when you start up a large test like ui_tests with
BROWSER_WRAPPER where you don't see the tool output at all...
We've had this --tool_flags for 2+ years for Valgrind-based tools and looks like
only Chrome-Valgrind team ever needed it :)

You can re-formulate and put back the TODO if you still think we should do w/o
--tool_flags.

Powered by Google App Engine
This is Rietveld 408576698