Issue 7585030: Added fast detection of one character tokens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7585030: Added fast detection of one character tokens. (Closed)

Created:
9 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 4 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Added fast detection of one character tokens. Reduced size of first-character table for keyword scanner. Committed: http://code.google.com/p/v8/source/detail?r=8862

Patch Set 2 : Added asserts. #

Total comments: 3

Patch Set 3 : Added semicolon. Removed 0x30. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -3 lines)			Patch
	M	src/scanner-base.h	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
	M	src/scanner-base.cc	View	1 2	1 chunk	+148 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM, you could add semicolon http://codereview.chromium.org/7585030/diff/4/src/scanner-base.cc File src/scanner-base.cc (right): http://codereview.chromium.org/7585030/diff/4/src/scanner-base.cc#newcode146 src/scanner-base.cc:146: Token::ILLEGAL, // 0x30 Why?

9 years, 4 months ago (2011-08-09 10:16:19 UTC) #2

Lasse Reichstein

9 years, 4 months ago (2011-08-09 11:27:12 UTC) #3

http://codereview.chromium.org/7585030/diff/4/src/scanner-base.cc
File src/scanner-base.cc (right):

http://codereview.chromium.org/7585030/diff/4/src/scanner-base.cc#newcode146
src/scanner-base.cc:146: Token::ILLEGAL,      // 0x30
At some point I thought I wanted to know where I was in the table. I'll remove
it.

http://codereview.chromium.org/7585030/diff/4/src/scanner-base.cc#newcode157
src/scanner-base.cc:157: Token::ILLEGAL,
Added semicolon.