Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 7585029: base: Remove using declaration of MD5Digest now that hunspell was fixed. (Closed)

Created:
9 years, 4 months ago by tfarina
Modified:
9 years, 4 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

base: Remove using declaration of MD5Digest now that hunspell was fixed. BUG=None TEST=None R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95804

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M base/md5.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/web_socket_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/socket/web_socket_server_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 4 months ago (2011-08-06 22:32:32 UTC) #1
Evan Martin
9 years, 4 months ago (2011-08-07 20:37:24 UTC) #2
LGTM

On Sat, Aug 6, 2011 at 3:32 PM,  <tfarina@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> base: Remove using declaration of MD5Digest now that hunspell was fixed.
>
> BUG=None
> TEST=None
>
> R=evan@chromium.org
>
>
> Please review this at http://codereview.chromium.org/7585029/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M base/md5.h
>  M net/socket/web_socket_server_socket.cc
>
>
> Index: base/md5.h
> diff --git a/base/md5.h b/base/md5.h
> index
>
f67c365e46979e6c5911f96946ab644a804d8e09..915dd8b77a59a6bbf3dd62e4a6a55ed10c69fbc4
> 100644
> --- a/base/md5.h
> +++ b/base/md5.h
> @@ -67,7 +67,4 @@ BASE_EXPORT std::string MD5String(const StringPiece& str);
>
>  }  // namespace base
>
> -// TODO(tfarina): Fix third_party/hunspell then remove this hack.
> -using base::MD5Digest;
> -
>  #endif  // BASE_MD5_H_
> Index: net/socket/web_socket_server_socket.cc
> diff --git a/net/socket/web_socket_server_socket.cc
> b/net/socket/web_socket_server_socket.cc
> index
>
a793097cbc70a66b21dd322c6e9998070eec824c..7b17ae739dca0d37b075630a960290aff6a87483
> 100644
> --- a/net/socket/web_socket_server_socket.cc
> +++ b/net/socket/web_socket_server_socket.cc
> @@ -699,8 +699,8 @@ class WebSocketServerSocketImpl : public
> net::WebSocketServerSocket {
>     memcpy(challenge, &part1, 4);
>     memcpy(challenge + 4, &part2, 4);
>     memcpy(challenge + 4 + 4, key3, sizeof(key3));
> -    MD5Digest challenge_response;
> -    MD5Sum(challenge, sizeof(challenge), &challenge_response);
> +    base::MD5Digest challenge_response;
> +    base::MD5Sum(challenge, sizeof(challenge), &challenge_response);
>
>     // Concocting response handshake.
>     class Buffer {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698