Issue 7585028: NativeWidgetViews: Implement widget activation/deactivation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7585028: NativeWidgetViews: Implement widget activation/deactivation. (Closed)

Created:
9 years, 4 months ago by sadrul

Modified:
9 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr., dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

NativeWidgetViews: Implement widget activation/deactivation. BUG=none TEST=WidgetObserverTest.ActivationChange Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95828

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -12 lines)			Patch
M	views/desktop/desktop_window_view.cc	View	2 chunks	+9 lines, -6 lines	0 comments	Download
M	views/widget/native_widget_views.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_views.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	views/widget/widget_unittest.cc	View	2 chunks	+7 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sadrul

http://codereview.chromium.org/7585028/diff/1/views/widget/widget_unittest.cc File views/widget/widget_unittest.cc (right): http://codereview.chromium.org/7585028/diff/1/views/widget/widget_unittest.cc#newcode590 views/widget/widget_unittest.cc:590: widget_activated_->Deactivate(); I would've liked to avoid doing this in ...

9 years, 4 months ago (2011-08-07 04:25:08 UTC) #1

LGTM

Expand Messages | Collapse Messages