Issue 7585020: Remove Autofill support for the ECML standard, as it is virtually unused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7585020: Remove Autofill support for the ECML standard, as it is virtually unused. (Closed)

Created:
9 years, 4 months ago by Ilya Sherman

Modified:
9 years, 4 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, GeorgeY, Paweł Hajdan Jr., Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove Autofill support for the ECML standard, as it is virtually unused. BUG=91873 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95865

Patch Set 1 #

Patch Set 2 : Remove ECML files from the repository #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -950 lines)			Patch
M	chrome/browser/autofill/address_field.h	View		2 chunks	+1 line, -14 lines	0 comments	Download
M	chrome/browser/autofill/address_field.cc	View		7 chunks	+43 lines, -114 lines	0 comments	Download
M	chrome/browser/autofill/address_field_unittest.cc	View		21 chunks	+16 lines, -167 lines	0 comments	Download
D	chrome/browser/autofill/autofill_ecml.h	View	1	1 chunk	+0 lines, -74 lines	0 comments	Download
D	chrome/browser/autofill/autofill_ecml.cc	View	1	1 chunk	+0 lines, -139 lines	0 comments	Download
M	chrome/browser/autofill/credit_card_field.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/autofill/credit_card_field.cc	View		6 chunks	+11 lines, -42 lines	0 comments	Download
M	chrome/browser/autofill/credit_card_field_unittest.cc	View		11 chunks	+11 lines, -122 lines	0 comments	Download
M	chrome/browser/autofill/email_field.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autofill/email_field.cc	View		1 chunk	+3 lines, -11 lines	0 comments	Download
M	chrome/browser/autofill/form_field.h	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/autofill/form_field.cc	View		5 chunks	+6 lines, -15 lines	0 comments	Download
M	chrome/browser/autofill/name_field.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/autofill/name_field.cc	View		4 chunks	+5 lines, -34 lines	0 comments	Download
M	chrome/browser/autofill/name_field_unittest.cc	View		12 chunks	+12 lines, -88 lines	0 comments	Download
M	chrome/browser/autofill/phone_field.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/autofill/phone_field.cc	View		4 chunks	+1 line, -21 lines	0 comments	Download
M	chrome/browser/autofill/phone_field_unittest.cc	View		12 chunks	+13 lines, -92 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

Please tick the commit queue check box if all looks good.

9 years, 4 months ago (2011-08-05 21:34:07 UTC) #1

dhollowa

9 years, 4 months ago (2011-08-08 01:06:20 UTC) #2

On 2011/08/05 21:34:07, Ilya Sherman wrote:
> Please tick the commit queue check box if all looks good.

LGTM except that autofill_ecml.cc/h should be removed from the repo.

Expand Messages | Collapse Messages