Add unit test for javascript: URL stripping

Add unit test for the javascript: URL blocking code.

BUG=91851
TEST=unit_tests:OmniboxView.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95669

[Tom Sepez, 2011-08-05 20:07:18]

Peter, might as well keep the simple unit test although trashing the rest of the
CL.  Thanks.

[Peter Kasting, 2011-08-05 20:10:22]

LGTM

http://codereview.chromium.org/7585016/diff/4001/chrome/browser/ui/omnibox/om...
File chrome/browser/ui/omnibox/omnibox_view_unittest.cc (right):

http://codereview.chromium.org/7585016/diff/4001/chrome/browser/ui/omnibox/om...
chrome/browser/ui/omnibox/omnibox_view_unittest.cc:12: 
Nit: Extra newline

http://codereview.chromium.org/7585016/diff/4001/chrome/browser/ui/omnibox/om...
chrome/browser/ui/omnibox/omnibox_view_unittest.cc:15: "javAscript:alert(0)",   
                      // Unsafe JS URL.
Can you also add one more like:

"   jav\nascript:alert(0)"

To test leading whitespace and newlines interrupting "javascript"?

http://codereview.chromium.org/7585016/diff/4001/chrome/browser/ui/omnibox/om...
chrome/browser/ui/omnibox/omnibox_view_unittest.cc:26: string16 url =
ASCIIToUTF16(urls[i]);
Nit: I'd probably roll at least these first two directly into the statements
below.

[Tom Sepez, 2011-08-05 20:26:09]

http://codereview.chromium.org/7585016/diff/4001/chrome/browser/ui/omnibox/om...
File chrome/browser/ui/omnibox/omnibox_view_unittest.cc (right):

http://codereview.chromium.org/7585016/diff/4001/chrome/browser/ui/omnibox/om...
chrome/browser/ui/omnibox/omnibox_view_unittest.cc:12: 
On 2011/08/05 20:10:22, Peter Kasting wrote:
> Nit: Extra newline

Done.

http://codereview.chromium.org/7585016/diff/4001/chrome/browser/ui/omnibox/om...
chrome/browser/ui/omnibox/omnibox_view_unittest.cc:15: "javAscript:alert(0)",   
                      // Unsafe JS URL.
> To test leading whitespace and newlines interrupting "javascript"?

Flunks.  The compaction occurs above this method.  Should it move down here (eg.
there's a strip call in the mac / win code before the calls to this).

http://codereview.chromium.org/7585016/diff/4001/chrome/browser/ui/omnibox/om...
chrome/browser/ui/omnibox/omnibox_view_unittest.cc:26: string16 url =
ASCIIToUTF16(urls[i]);
On 2011/08/05 20:10:22, Peter Kasting wrote:
> Nit: I'd probably roll at least these first two directly into the statements
> below.

Done.

[Peter Kasting, 2011-08-05 20:28:18]

http://codereview.chromium.org/7585016/diff/4001/chrome/browser/ui/omnibox/om...
File chrome/browser/ui/omnibox/omnibox_view_unittest.cc (right):

http://codereview.chromium.org/7585016/diff/4001/chrome/browser/ui/omnibox/om...
chrome/browser/ui/omnibox/omnibox_view_unittest.cc:15: "javAscript:alert(0)",   
                      // Unsafe JS URL.
On 2011/08/05 20:26:09, Tom Sepez wrote:
> > To test leading whitespace and newlines interrupting "javascript"?
> 
> Flunks.  The compaction occurs above this method.  Should it move down here
(eg.
> there's a strip call in the mac / win code before the calls to this).

Ah, I see.  Nah, just leave this testcase out.

[Tom Sepez, 2011-08-05 20:51:15]

unit_test only runs on PS #2:
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/41290
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/47096
mac bot seems kind of backed up :(.

[Tom Sepez, 2011-08-05 22:17:33]

http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/41560