Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 7585015: Printing: Remove unused PageOverlay since header/footers are drawn in PrintWebViewHelper. (Closed)

Created:
9 years, 4 months ago by Lei Zhang
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Printing: Remove unused PageOverlay since header/footers are drawn in PrintWebViewHelper. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95951

Patch Set 1 #

Patch Set 2 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -637 lines) Patch
D printing/page_overlays.h View 1 chunk +0 lines, -82 lines 0 comments Download
D printing/page_overlays.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D printing/page_overlays_unittest.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M printing/print_settings.h View 2 chunks +2 lines, -4 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printed_document.h View 4 chunks +0 lines, -28 lines 0 comments Download
M printing/printed_document.cc View 3 chunks +0 lines, -76 lines 0 comments Download
M printing/printed_document_cairo.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M printing/printed_document_mac.cc View 1 chunk +0 lines, -8 lines 0 comments Download
D printing/printed_document_posix.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M printing/printed_document_win.cc View 1 3 chunks +0 lines, -106 lines 0 comments Download
M printing/printing.gyp View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
goodbye old code.
9 years, 4 months ago (2011-08-06 00:55:24 UTC) #1
vandebo (ex-Chrome)
LGTM
9 years, 4 months ago (2011-08-08 21:28:34 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-09 06:06:59 UTC) #3
Change committed as 95951

Powered by Google App Engine
This is Rietveld 408576698