Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 7585013: mac: Window buttons should keep "active" view when bubbles / tabpose are open on 10.7 (Closed)

Created:
9 years, 4 months ago by Nico
Modified:
9 years, 4 months ago
CC:
chromium-reviews, rohitrao (ping after 24h)
Visibility:
Public.

Description

mac: Window buttons should keep "active" view when bubbles / tabpose are open on 10.7 This matches the behavior of NSPopover. This is done by overriding the SPI _sharesParentKeyState, which works on 10.7 but not on 10.6. If we want to get this right on 10.6, we could use the SPI described in http://code.google.com/p/chromium/issues/detail?id=44087#c42 , but since we didn't feel we need this until now, we can probably live with this being 10.7-only. I do need this functionality for the history-swipe-overlay. BUG=none TEST=Click e.g. bookmark star. Bookmark bubble should appear, browser window close button should still look active. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95708

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/info_bubble_window.mm View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
http://codereview.chromium.org/7585013/diff/10/chrome/browser/ui/cocoa/info_bubble_window.mm File chrome/browser/ui/cocoa/info_bubble_window.mm (right): http://codereview.chromium.org/7585013/diff/10/chrome/browser/ui/cocoa/info_bubble_window.mm#newcode142 chrome/browser/ui/cocoa/info_bubble_window.mm:142: - (BOOL)_sharesParentKeyState { Should comment what this does and ...
9 years, 4 months ago (2011-08-05 19:19:43 UTC) #1
Nico
ptal
9 years, 4 months ago (2011-08-05 21:37:46 UTC) #2
Robert Sesek
LGTM
9 years, 4 months ago (2011-08-05 21:38:34 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-06 01:16:15 UTC) #4
Change committed as 95708

Powered by Google App Engine
This is Rietveld 408576698