Fix print preview draft page memory leaks.

Fix print preview draft page memory leaks.

BUG=91862
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95722

[Lei Zhang, 2011-08-05 19:37:31]

LGTM

BTW, this needs to be merged into M14 right? If so, can you create a bug to
associate this CL with so we can ask for merge approval?

http://codereview.chromium.org/7585012/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper_mac.mm (right):

http://codereview.chromium.org/7585012/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_mac.mm:99: draft_metafile->RenderPage(1,
offtopic: Aren't you drawing into |print_preview_context_.metafile()| twice when
print_preview_context_.IsModifiable() is false?

[kmadhusu, 2011-08-05 19:46:42]

LGTM

[kmadhusu, 2011-08-05 20:02:11]

http://codereview.chromium.org/7585012/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper_mac.mm (right):

http://codereview.chromium.org/7585012/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_mac.mm:111:
PreviewPageRendered(page_number, draft_metafile);
Did you miss to change the second param to "draft_metafile.get()"?

[vandebo (ex-Chrome), 2011-08-05 20:56:26]

On 2011/08/05 19:37:31, Lei Zhang wrote:
> BTW, this needs to be merged into M14 right? If so, can you create a bug to
> associate this CL with so we can ask for merge approval?

Done.

http://codereview.chromium.org/7585012/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper_mac.mm (right):

http://codereview.chromium.org/7585012/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_mac.mm:99: draft_metafile->RenderPage(1,
On 2011/08/05 19:37:31, Lei Zhang wrote:
> offtopic: Aren't you drawing into |print_preview_context_.metafile()| twice
when
> print_preview_context_.IsModifiable() is false?

No, this is inside the if(print_preview_context_.IsModifiable()) starting on
line 89.

http://codereview.chromium.org/7585012/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_mac.mm:111:
PreviewPageRendered(page_number, draft_metafile);
On 2011/08/05 20:02:11, kmadhusu wrote:
> Did you miss to change the second param to "draft_metafile.get()"?

Done.

[kmadhusu, 2011-08-05 21:09:32]

LGTM

[commit-bot: I haz the power, 2011-08-06 03:20:00]

Change committed as 95722