Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 7585004: Fix bug in scanner. (Closed)

Created:
9 years, 4 months ago by Lasse Reichstein
Modified:
9 years, 4 months ago
Reviewers:
Patrick Nepper, Rico
CC:
v8-dev
Visibility:
Public.

Description

Fix bug in scanner. Checking for end-of-comment truncated to byte before comparing to '*'. BUG=v8:1546 TEST=mjsunit/regress/regress-1546 Committed: http://code.google.com/p/v8/source/detail?r=8842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M src/scanner-base.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-1546.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 4 months ago (2011-08-05 10:20:37 UTC) #1
Rico
LGTM
9 years, 4 months ago (2011-08-05 10:30:41 UTC) #2
Patrick Nepper
9 years, 4 months ago (2011-08-05 12:20:04 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698