chrome/common/extensions/extension_file_util.h - Issue 7585003: Fix to make Chromium more verbose about component extension loading error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_file_util.h

Issue 7585003: Fix to make Chromium more verbose about component extension loading error (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/extensions/extension_service.cc ('k') | chrome/common/extensions/extension_file_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_file_util.h

diff --git a/chrome/common/extensions/extension_file_util.h b/chrome/common/extensions/extension_file_util.h

index 114549f7bffbf2dd59487d5365cf06a55adeb0b6..7913e2f736a5d2fd57727b2f0da8b7c3557e6f26 100644

--- a/chrome/common/extensions/extension_file_util.h

+++ b/chrome/common/extensions/extension_file_util.h

@@ -44,7 +44,7 @@ scoped_refptr<Extension> LoadExtension(const FilePath& extension_root,

// Returns true if the given extension object is valid and consistent.

// Otherwise, a description of the error is returned in |error|.

-bool ValidateExtension(Extension* extension, std::string* error);

+bool ValidateExtension(const Extension* extension, std::string* error);

// Cleans up the extension install directory. It can end up with garbage in it

// if extensions can't initially be removed when they are uninstalled (eg if a