Fix to make Chromium more verbose about component extension loading error

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 1059 matching lines @@
        it != component_extension_manifests_.end(); ++it) {
     LoadComponentExtension(*it);
   }
 }
 
 const Extension* ExtensionService::LoadComponentExtension(
     const ComponentExtensionInfo &info) {
   JSONStringValueSerializer serializer(info.manifest);
   scoped_ptr<Value> manifest(serializer.Deserialize(NULL, NULL));
   if (!manifest.get()) {
-    DLOG(ERROR) << "Failed to parse manifest for extension";
+    LOG(ERROR) << "Failed to parse manifest for extension";
     return NULL;
   }
 
   int flags = Extension::REQUIRE_KEY;
   if (Extension::ShouldDoStrictErrorChecking(Extension::COMPONENT))
     flags |= Extension::STRICT_ERROR_CHECKS;
   std::string error;
   scoped_refptr<const Extension> extension(Extension::Create(
       info.root_directory,
       Extension::COMPONENT,
       *static_cast<DictionaryValue*>(manifest.get()),
       flags,
       &error));
   if (!extension.get()) {
-    NOTREACHED() << error;
+    LOG(ERROR) << error;
     return NULL;
   }
+  if (!extension_file_util::ValidateExtension(extension, &error)) {

[Aaron Boodman, 2011/08/08 21:31:42]

Please remove this.

Component extensions must be fast to load since they are enabled by default with
every build. In particular, they should not cause any file IO in the typical
case.

This adds a bunch of file IO, and not only that puts it on the UI thread. Chrome
must never do file IO on the UI thread.

It's better to have component extensions be a bit harder to debug than to slow
down Chrome's normal startup path.

[hashimoto, 2011/08/09 06:19:52]

Thank you for your detailed explanation.

I abandoned this part and switched to make more log when the content of an
extension is actually loaded. ( http://codereview.chromium.org/7528021/ )

On 2011/08/08 21:31:42, Aaron Boodman wrote:

+    LOG(ERROR) << error;
+  }
   AddExtension(extension);
   return extension;
 }
 
 void ExtensionService::UnloadComponentExtension(
     const ComponentExtensionInfo& info) {
   JSONStringValueSerializer serializer(info.manifest);
   scoped_ptr<Value> manifest(serializer.Deserialize(NULL, NULL));
   if (!manifest.get()) {
-    DLOG(ERROR) << "Failed to parse manifest for extension";
+    LOG(ERROR) << "Failed to parse manifest for extension";
     return;
   }
   std::string public_key;
   std::string public_key_bytes;
   std::string id;
   if (!static_cast<DictionaryValue*>(manifest.get())->
       GetString(extension_manifest_keys::kPublicKey, &public_key) ||
       !Extension::ParsePEMKeyBytes(public_key, &public_key_bytes) ||
       !Extension::GenerateId(public_key_bytes, &id)) {
-    DLOG(ERROR) << "Failed to get extension id";
+    LOG(ERROR) << "Failed to get extension id";
     return;
   }
   UnloadExtension(id, UnloadedExtensionInfo::DISABLE);
 }
 
 void ExtensionService::LoadAllExtensions() {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   base::TimeTicks start_time = base::TimeTicks::Now();
 
@@ skipping 1453 matching lines @@
 
 ExtensionService::NaClModuleInfoList::iterator
     ExtensionService::FindNaClModule(const GURL& url) {
   for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
        iter != nacl_module_list_.end(); ++iter) {
     if (iter->url == url)
       return iter;
   }
   return nacl_module_list_.end();
 }