Issue 7584033: Fix memory leak in MediaLog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7584033: Fix memory leak in MediaLog. (Closed)

Created:
9 years, 4 months ago by Scott Franklin

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, dhollowa

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, pam+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix memory leak in MediaLog. BUG=91896 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95884

Patch Set 1 #

Patch Set 2 : Merge with trunk. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -73 lines)			Patch
	M	media/base/media_log.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
	M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+0 lines, -72 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Scott Franklin

Oops, forgot to make my do-nothing implementation for tests clean up after itself properly.

9 years, 4 months ago (2011-08-08 20:48:45 UTC) #1

commit-bot: I haz the power

9 years, 4 months ago (2011-08-08 21:03:51 UTC) #3

Can't apply patch for file tools/heapcheck/suppressions.txt.
While running patch -p1 --forward --force;
patching file tools/heapcheck/suppressions.txt
Hunk #1 FAILED at 1928.
1 out of 1 hunk FAILED -- saving rejects to file
tools/heapcheck/suppressions.txt.rej

Expand Messages | Collapse Messages