base/string_number_conversions.cc - Issue 7584031: base::HexStringToInt conversion function treats the string "0x" as a valid hex number

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/string_number_conversions.cc

Issue 7584031: base::HexStringToInt conversion function treats the string "0x" as a valid hex number (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/string_number_conversions.cc

===================================================================

--- base/string_number_conversions.cc (revision 95764)

+++ base/string_number_conversions.cc (working copy)

@@ -220,7 +220,7 @@

// Note: no performance difference was found when using template

// specialization to remove this check in bases other than 16

- if (traits::kBase == 16 && end - begin >= 2 && *begin == '0' &&

+ if (traits::kBase == 16 && end - begin > 2 && *begin == '0' &&

(*(begin + 1) == 'x' || *(begin + 1) == 'X')) {

begin += 2;

}

« no previous file with comments | « AUTHORS ('k') | base/string_number_conversions_unittest.cc » ('j') | no next file with comments »