Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 7584030: Disable nacl_integration on mac debug for now. (Closed)

Created:
9 years, 4 months ago by Nico
Modified:
9 years, 4 months ago
Reviewers:
Mark Seaborn, M-A Ruel
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disable nacl_integration on mac debug for now. BUG=91371 TEST=none TBR=mseaborn Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95819

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/test/nacl_test_injection/buildbot_nacl_integration.py View 1 chunk +9 lines, -0 lines 7 comments Download

Messages

Total messages: 4 (0 generated)
Nico
9 years, 4 months ago (2011-08-08 16:06:01 UTC) #1
M-A Ruel
lgtm, maybe a few nits Mark may look at eventually if he wants. http://codereview.chromium.org/7584030/diff/1/chrome/test/nacl_test_injection/buildbot_nacl_integration.py File ...
9 years, 4 months ago (2011-08-08 16:16:53 UTC) #2
Nico
http://codereview.chromium.org/7584030/diff/1/chrome/test/nacl_test_injection/buildbot_nacl_integration.py File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right): http://codereview.chromium.org/7584030/diff/1/chrome/test/nacl_test_injection/buildbot_nacl_integration.py#newcode14 chrome/test/nacl_test_injection/buildbot_nacl_integration.py:14: On 2011/08/08 16:16:53, Marc-Antoine Ruel wrote: > one line ...
9 years, 4 months ago (2011-08-08 16:19:35 UTC) #3
Mark Seaborn
9 years, 4 months ago (2011-08-08 16:25:36 UTC) #4
http://codereview.chromium.org/7584030/diff/1/chrome/test/nacl_test_injection...
File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right):

http://codereview.chromium.org/7584030/diff/1/chrome/test/nacl_test_injection...
chrome/test/nacl_test_injection/buildbot_nacl_integration.py:16: if sys.platform
== 'darwin' and 'Debug' in args:
This should really be inside an "if not is_integration_bot" conditional,
otherwise it (potentially) disables tests on the NaCl/Chrome integration bot. 
Not very important, though, since we happen to do a Release build on those bots
at the moment.

http://codereview.chromium.org/7584030/diff/1/chrome/test/nacl_test_injection...
chrome/test/nacl_test_injection/buildbot_nacl_integration.py:21:
sys.stdout.flush()
You don't need to flush if you're exiting straight away.

Powered by Google App Engine
This is Rietveld 408576698