Issue 7584029: Fixed TPM dialog shield style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7584029: Fixed TPM dialog shield style (Closed)

Created:
9 years, 4 months ago by whywhat

Modified:
9 years, 4 months ago

Reviewers:
altimofeev

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixed TPM dialog shield style R=altimofeev BUG=chromium-os:17335 TEST=Click on Learn More link on EULA screen. Verify that shadow that blocks the UI is of correct style. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95963

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated #

Patch Set 3 : Fixed comments #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	chrome/browser/resources/chromeos/login/oobe.css	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

altimofeev

LGTM http://codereview.chromium.org/7584029/diff/1/chrome/browser/resources/chromeos/login/oobe.css File chrome/browser/resources/chromeos/login/oobe.css (right): http://codereview.chromium.org/7584029/diff/1/chrome/browser/resources/chromeos/login/oobe.css#newcode107 chrome/browser/resources/chromeos/login/oobe.css:107: is it needed? http://codereview.chromium.org/7584029/diff/1/chrome/browser/resources/chromeos/login/oobe.css#newcode356 chrome/browser/resources/chromeos/login/oobe.css:356: background: #ffffff; nit: ...

9 years, 4 months ago (2011-08-08 17:14:44 UTC) #2

All done. Uploaded incorrect diff initially.

Expand Messages | Collapse Messages