Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5772)

Unified Diff: chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc

Issue 7584024: views omnibox popup: Setup the parent Widget, instead of the parent NativeView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
diff --git a/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc b/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
index 92c55ccc8e11f57c027e31377f1f01c9e7476a4c..f82f0d5eb8dc62b307750f300bb758251640cb7f 100644
--- a/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
+++ b/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
@@ -230,7 +230,7 @@ AutocompletePopupContentsView::AutocompletePopupContentsView(
OmniboxView* omnibox_view,
AutocompleteEditModel* edit_model,
Profile* profile,
- const views::View* location_bar)
+ views::View* location_bar)
: model_(new AutocompletePopupModel(this, edit_model, profile)),
opt_in_view_(NULL),
omnibox_view_(omnibox_view),
@@ -357,7 +357,7 @@ void AutocompletePopupContentsView::UpdatePopupAppearance() {
views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);
params.can_activate = false;
params.transparent = true;
- params.parent = location_bar_->GetWidget()->GetNativeView();
+ params.parent_widget = location_bar_->GetWidget();
sky 2011/08/08 16:35:28 Should InitParams parent_widget be a const* Widget
sadrul 2011/08/08 17:05:33 I think that'll be very difficult, considering NWV
params.bounds = GetPopupBounds();
popup_->Init(params);
popup_->SetContentsView(this);

Powered by Google App Engine
This is Rietveld 408576698