Issue 7584021: Revert 95698 - Implement touch selection for RWHVV.

Issue 7584021: Revert 95698 - Implement touch selection for RWHVV. (Closed)

Created:
9 years, 4 months ago by yzshen1

Modified:
9 years, 4 months ago

Reviewers:
varunjain

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 95698 - Implement touch selection for RWHVV. BUG=none TEST=none Review URL: http://codereview.chromium.org/7570001 TBR=varunjain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95705

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -123 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_gtk.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_mac.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views.h	View	5 chunks	+2 lines, -19 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views.cc	View	3 chunks	+2 lines, -36 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	content/common/view_messages.h	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	content/renderer/render_view.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	content/renderer/render_view.cc	View	5 chunks	+3 lines, -30 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yzshen1

9 years, 4 months ago (2011-08-06 01:00:19 UTC) #2

On 2011/08/06 00:58:13, yzshen1 wrote:

It seems to fail the linux touch bot:

[ RUN      ] RenderWidgetHostTest.Background
[14280:14280:0805/174437:631934813156:ERROR:process_util_posix.cc(134)] Received
signal 11
	base::debug::StackTrace::StackTrace() [0x206650e]
	base::(anonymous namespace)::StackDumpSignalHandler() [0x2043f13]
	0x7f8a3b29baf0
	views::internal::NativeWidgetPrivate::CreateNativeWidget() [0x1fa6ba2]
	views::Widget::Init() [0x1fac238]
	views::TouchSelectionControllerImpl::TouchSelectionControllerImpl() [0x1f9757b]
	views::TouchSelectionController::create() [0x1f976b9]
	RenderWidgetHostViewViews::RenderWidgetHostViewViews() [0x18dd9ae]
	RenderWidgetHostView::CreateViewForWidget() [0x15fc189]
	RenderWidgetHostTest_Background_Test::TestBody() [0x1100585]
	testing::Test::Run() [0x1ca9681]
	testing::TestInfo::Run() [0x1ca974a]
	testing::TestCase::Run() [0x1ca9897]
	testing::internal::UnitTestImpl::RunAllTests() [0x1ca9b2d]
	testing::UnitTest::Run() [0x1ca8233]
	base::TestSuite::Run() [0x32591d8]
	main [0x1d07bcb]
	0x7f8a3b286c4d
	0x4335c9

Expand Messages | Collapse Messages