Fix generation of the complete metafile for print preview flow.

Fix generation of the complete metafile for print preview flow.

- Start/Finish page was missing.
- transform was off as well.
- This CL is on top of http://codereview.chromium.org/7585012/

BUG=91727
TEST=View saved PDF form print preview, content and margins should be correct.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95844

[kmadhusu, 2011-08-05 23:33:52]

http://codereview.chromium.org/7584019/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper_mac.mm (right):

http://codereview.chromium.org/7584019/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_mac.mm:101: printParams.page_size,
gfx::Rect(printParams.page_size), 1.0);
Please document that the scale factor is always 1.0.

http://codereview.chromium.org/7584019/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_mac.mm:101: printParams.page_size,
gfx::Rect(printParams.page_size), 1.0);
Why can't we use the content_area rather than
"gfx::Rect(printParams.page_size)"?

http://codereview.chromium.org/7584019/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_mac.mm:112: false /*shrink_to_fit*/,
style nit: Add a space after "/*" and before "*/".

[vandebo (ex-Chrome), 2011-08-06 00:43:43]

http://codereview.chromium.org/7584019/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper_mac.mm (right):

http://codereview.chromium.org/7584019/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_mac.mm:101: printParams.page_size,
gfx::Rect(printParams.page_size), 1.0);
On 2011/08/05 23:33:52, kmadhusu wrote:
> Please document that the scale factor is always 1.0.

Done.

http://codereview.chromium.org/7584019/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_mac.mm:101: printParams.page_size,
gfx::Rect(printParams.page_size), 1.0);
On 2011/08/05 23:33:52, kmadhusu wrote:
> Why can't we use the content_area rather than
> "gfx::Rect(printParams.page_size)"?

Because we want a 1:1 rendering of the source PDF, we need to draw into the
entire page (arg I've specified), not the content area (smaller).

http://codereview.chromium.org/7584019/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_mac.mm:112: false /*shrink_to_fit*/,
On 2011/08/05 23:33:52, kmadhusu wrote:
> style nit: Add a space after "/*" and before "*/".

Done.

[kmadhusu, 2011-08-06 21:11:35]

LGTM with a nit

http://codereview.chromium.org/7584019/diff/3001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper_mac.mm (right):

http://codereview.chromium.org/7584019/diff/3001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper_mac.mm:105: // was already flipped in
draft_metafile.
nit: "draft_metafile " => "|draft_metafile|"

[vandebo (ex-Chrome), 2011-08-08 17:17:30]

Sent to commit queue

http://codereview.chromium.org/7584019/diff/3001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper_mac.mm (right):

http://codereview.chromium.org/7584019/diff/3001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper_mac.mm:105: // was already flipped in
draft_metafile.
On 2011/08/06 21:11:35, kmadhusu wrote:
> nit: "draft_metafile " => "|draft_metafile|"

Done.

[commit-bot: I haz the power, 2011-08-08 18:51:14]

Change committed as 95844