Issue 7584015: [Mac] Fix avatar size after new icon drop. The image scaling behaves weird in a button cell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7584015: [Mac] Fix avatar size after new icon drop. The image scaling behaves weird in a button cell. (Closed)

Created:
9 years, 4 months ago by Robert Sesek

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, sail

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Mac] Fix avatar size after new icon drop. The image scaling behaves weird in a button cell. BUG=none TEST=With multi profiles enabled, avatars aren't smaller than they should be. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96490

Patch Set 1 #

Total comments: 1

Patch Set 2 : Different approach #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/ui/cocoa/browser/avatar_button.mm	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sail

http://codereview.chromium.org/7584015/diff/1/chrome/browser/ui/cocoa/browser/avatar_button.mm File chrome/browser/ui/cocoa/browser/avatar_button.mm (right): http://codereview.chromium.org/7584015/diff/1/chrome/browser/ui/cocoa/browser/avatar_button.mm#newcode88 chrome/browser/ui/cocoa/browser/avatar_button.mm:88: [[button_ cell] setImageScaling:NSImageScaleNone]; It might be a good idea ...

9 years, 4 months ago (2011-08-05 21:36:44 UTC) #2

Change committed as 96490

Expand Messages | Collapse Messages