Issue 7584011: Fix DCHECK in P2PSocketClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7584011: Fix DCHECK in P2PSocketClient. (Closed)

Created:
9 years, 4 months ago by Sergey Ulanov

Modified:
9 years, 4 months ago

Reviewers:
awong, garykac

CC:
chromium-reviews, joi+watch-content_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix DCHECK in P2PSocketClient. P2PSocketClient may DCHECK in Close() if Close() is called immediately after Init() because delegate_message_loop_ is initialized on the IPC thread. Initialize it in the constructor instead. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95697

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -11 lines)			Patch
M	content/renderer/p2p/ipc_socket_factory.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/renderer/p2p/socket_client.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/renderer/p2p/socket_client.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

yay.

Expand Messages | Collapse Messages