Keeping the current directory in URL.

Keeping the current directory in URL.

It makes the refresh button on the file manager working in intuitive manner. Also now it's possible to set a bookmark to a specific directory or enter directory path in the omnibox.

BUG=chromium-os:17787
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95621

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96199

[SeRya, 2011-08-05 09:50:08]

Please review.

[Vladislav Kaznacheev, 2011-08-05 13:01:31]

http://codereview.chromium.org/7584004/diff/6/chrome/browser/extensions/file_...
File chrome/browser/extensions/file_manager_util.cc (right):

http://codereview.chromium.org/7584004/diff/6/chrome/browser/extensions/file_...
chrome/browser/extensions/file_manager_util.cc:156: DictionaryValue arg_value;
Any special reason to inline the helper function? It actually looked pretty
reasonable.

http://codereview.chromium.org/7584004/diff/6/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/7584004/diff/6/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:1043: * reload) or
popping a state (after ckick on back/forward). If location.hash
typo: ckick -> click
presents -> is present

http://codereview.chromium.org/7584004/diff/6/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:2020: console.log('Push
state: ' + location);
I do not think we need this logging in production

http://codereview.chromium.org/7584004/diff/6/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/main.js (right):

http://codereview.chromium.org/7584004/diff/6/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/main.js:16: var params;
Duplicate var declaration. Also, you are keeping this variable for logging only,
right?

[SeRya, 2011-08-05 13:45:41]

http://codereview.chromium.org/7584004/diff/6/chrome/browser/extensions/file_...
File chrome/browser/extensions/file_manager_util.cc (right):

http://codereview.chromium.org/7584004/diff/6/chrome/browser/extensions/file_...
chrome/browser/extensions/file_manager_util.cc:156: DictionaryValue arg_value;
On 2011/08/05 13:01:36, Vladislav Kaznacheev wrote:
> Any special reason to inline the helper function? It actually looked pretty
> reasonable.

This function is not used anywhere else anymore and does work what hardly make
sense in any other context. Equal list of parameters (quite long by the way) is
another sign that it should not exist.

http://codereview.chromium.org/7584004/diff/6/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/7584004/diff/6/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:1043: * reload) or
popping a state (after ckick on back/forward). If location.hash
On 2011/08/05 13:01:36, Vladislav Kaznacheev wrote:
> typo: ckick -> click
> presents -> is present

Done.

http://codereview.chromium.org/7584004/diff/6/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:2020: console.log('Push
state: ' + location);
On 2011/08/05 13:01:36, Vladislav Kaznacheev wrote:
> I do not think we need this logging in production

Removed.

http://codereview.chromium.org/7584004/diff/6/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/main.js (right):

http://codereview.chromium.org/7584004/diff/6/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/main.js:16: var params;
On 2011/08/05 13:01:36, Vladislav Kaznacheev wrote:
> Duplicate var declaration. Also, you are keeping this variable for logging
only,
> right?

I just lost a bit of changes while moved the patch from one place to another.
Fixed.

[Vladislav Kaznacheev, 2011-08-05 14:29:56]

LGTM

[commit-bot: I haz the power, 2011-08-05 16:16:46]

Change committed as 95621

[SeRya, 2011-08-08 18:24:47]

This CL have need reverted due to a linux_touch build failure:

chrome/browser/extensions/file_manager_util.cc: In static member function
'static void FileManagerUtil::ShowFullTabUrl(Profile*, const FilePath&)':
chrome/browser/extensions/file_manager_util.cc:212: error:
'kChromeUIFileManagerURL' is not a member of 'chrome'

I fixed chrome_browser.gypi to exclude filemanager related files from the
target.

[SeRya, 2011-08-08 18:25:02]

This CL have need reverted due to a linux_touch build failure:

chrome/browser/extensions/file_manager_util.cc: In static member function
'static void FileManagerUtil::ShowFullTabUrl(Profile*, const FilePath&)':
chrome/browser/extensions/file_manager_util.cc:212: error:
'kChromeUIFileManagerURL' is not a member of 'chrome'

I fixed chrome_browser.gypi to exclude filemanager related files from the
target.

[Vladislav Kaznacheev, 2011-08-10 09:50:06]

On 2011/08/08 18:25:02, SeRya wrote:
> This CL have need reverted due to a linux_touch build failure:
> 
> chrome/browser/extensions/file_manager_util.cc: In static member function
> 'static void FileManagerUtil::ShowFullTabUrl(Profile*, const FilePath&)':
> chrome/browser/extensions/file_manager_util.cc:212: error:
> 'kChromeUIFileManagerURL' is not a member of 'chrome'
> 
> I fixed chrome_browser.gypi to exclude filemanager related files from the
> target.

LGTM

[commit-bot: I haz the power, 2011-08-10 17:34:48]

Change committed as 96199