Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 7584002: Remove a br tag from a keyboard overlay message. (Closed)

Created:
9 years, 4 months ago by mazda
Modified:
9 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Remove a br tag from a keyboard overlay message. BUG=none TEST=Manually on the chromebook Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95822

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/keyboard_overlay.css View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mazda
9 years, 4 months ago (2011-08-05 07:24:48 UTC) #1
tony
Thanks, LGTM! http://codereview.chromium.org/7584002/diff/1001/chrome/browser/resources/keyboard_overlay.css File chrome/browser/resources/keyboard_overlay.css (right): http://codereview.chromium.org/7584002/diff/1001/chrome/browser/resources/keyboard_overlay.css#newcode29 chrome/browser/resources/keyboard_overlay.css:29: margin: 13px auto 0 auto; Nit: You ...
9 years, 4 months ago (2011-08-05 16:08:49 UTC) #2
mazda
http://codereview.chromium.org/7584002/diff/1001/chrome/browser/resources/keyboard_overlay.css File chrome/browser/resources/keyboard_overlay.css (right): http://codereview.chromium.org/7584002/diff/1001/chrome/browser/resources/keyboard_overlay.css#newcode29 chrome/browser/resources/keyboard_overlay.css:29: margin: 13px auto 0 auto; On 2011/08/05 16:08:49, tony ...
9 years, 4 months ago (2011-08-08 04:31:39 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 4 months ago (2011-08-08 10:03:40 UTC) #4
M-A Ruel
On 2011/08/08 10:03:40, I haz the power (commit-bot) wrote: > The commit queue went berserk ...
9 years, 4 months ago (2011-08-08 13:00:00 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-08 16:21:23 UTC) #6
Change committed as 95822

Powered by Google App Engine
This is Rietveld 408576698