Adding a format device button to UI.

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 const EMPTY_IMAGE_URI = 'data:image/gif;base64,'
         + 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw%3D%3D';
 
 var g_slideshow_data = null;
@@ skipping 1453 matching lines @@
       if (pendingFiles.length) {
         cacheEntrySize(pendingFiles.pop(), cacheNextFile);
       } else {
         self.dispatchEvent(new cr.Event('selection-summarized'));
       }
     };
 
     if (this.dialogType_ == FileManager.DialogType.FULL_PAGE) {
       // Since unmount task cannot be defined in terms of file patterns,
       // we manually include it here, if all selected items are mount points.
+      this.taskButtons_.innerHTML = '';
       chrome.fileBrowserPrivate.getFileTasks(
           selection.urls,
           this.onTasksFound_.bind(this,
                                   this.shouldShowUnmount_(selection.urls)));
+      // This needs to be done in sparate function, as check requires
+      // asynchronous function calls.
+      this.DisplayFormattingTask1_(selection.entries);
     }
 
     cacheNextFile();
   };
 
   FileManager.prototype.onMetadataResult_ = function(fileURL, metadata) {
     var observers = this.metadataCache_[fileURL];
     if (!observers || !(observers instanceof Array)) {
       console.error('Missing or invalid metadata observers: ' + fileURL + ': ' +
                     observers);
@@ skipping 54 matching lines @@
    * @param {Array.<Task>} tasksList The tasks list.
    */
   FileManager.prototype.onTasksFound_ = function(unmount, tasksList) {
     if (unmount) {
       tasksList.push({
           taskId: this.getExtensionId_() + '|unmount-archive',
           iconUrl: '',
           title: ''
       });
     }
-
-    this.taskButtons_.innerHTML = '';
     for (var i = 0; i < tasksList.length; i++) {
       var task = tasksList[i];
 
       // Tweak images, titles of internal tasks.
       var task_parts = task.taskId.split('|');
       if (task_parts[0] == this.getExtensionId_()) {
         if (task_parts[1] == 'preview') {
           // TODO(serya): This hack needed until task.iconUrl get working
           //              (see GetFileTasksFileBrowserFunction::RunImpl).
           task.iconUrl =
@@ skipping 15 matching lines @@
         } else if (task_parts[1] == 'mount-archive') {
           task.iconUrl =
               chrome.extension.getURL('images/icon_mount_archive_16x16.png');
           task.title = str('MOUNT_ARCHIVE');
         } else if (task_parts[1] == 'unmount-archive') {
           task.iconUrl =
               chrome.extension.getURL('images/icon_unmount_archive_16x16.png');
           task.title = str('UNMOUNT_ARCHIVE');
         }
       }
-
-      var button = this.document_.createElement('button');
-      button.addEventListener('click', this.onTaskButtonClicked_.bind(this));
-      button.className = 'task-button';
-      button.task = task;
-
-      var img = this.document_.createElement('img');
-      img.src = task.iconUrl;
-
-      button.appendChild(img);
-      button.appendChild(this.document_.createTextNode(task.title));
-
-      this.taskButtons_.appendChild(button);
+      this.renderTaskButton_(task);
     }
   };
 
+  FileManager.prototype.renderTaskButton_ = function(task) {
+    var button = this.document_.createElement('button');
+    button.addEventListener('click', this.onTaskButtonClicked_.bind(this));
+    button.className = 'task-button';
+    button.task = task;
+
+    var img = this.document_.createElement('img');
+    img.src = task.iconUrl;
+
+    button.appendChild(img);
+    button.appendChild(this.document_.createTextNode(task.title));
+
+    this.taskButtons_.appendChild(button);
+  };
+
+  /**
+   * Checks whether formatting task should be displayed and if the answer is
+   * affirmative renders it. Includes asynchronous calls, so it's splitted into
+   * three parts.
+   */
+  FileManager.prototype.DisplayFormattingTask1_ = function(entries) {

[rginda, 2011/08/10 23:08:09]

JavaScript naming convention has leadingLowercase for anything that's not a
Constructor or a CONSTANT.

Since this may not actually create a button, and 'render' is used in a simliar
context near by, I'd suggest 'maybeRenderFormattingTask'.

[sidor.dev, 2011/08/10 23:51:21]

Done.

+    if (entries.length != 1)
+      return;
+    var self = this;
+    chrome.fileBrowserPrivate.getMountPoints(
+        this.DisplayFormattingTask2_.bind(this, entries[0].fullPath));
+  };
+
+  FileManager.prototype.DisplayFormattingTask2_ = function(mountPath,

[rginda, 2011/08/10 23:08:09]

The convention elsewhere in this file is to declare the async callbacks as
nested functions with descriptive names.  In this case, 'onMountPointsFound'
would be appropriate.

[sidor.dev, 2011/08/10 23:51:21]

Done.

+                                                           mountPoints) {
+    var normalize = function(x) {
+      if(x[0] == '/')
+        return x.slice(1);
+      else
+        return x;
+    }
+    this.mountPoints_ = mountPoints;
+    for (var i = 0; i < mountPoints.length; ++i) {

[rginda, 2011/08/10 23:08:09]

i++

[sidor.dev, 2011/08/10 23:51:21]

Done. Out of curiosity - why is that a convention in JS? In C++ it's usually
++i...

+      if (mountPoints[i].mountType == "device" &&
+          normalize(mountPoints[i].mountPath) == normalize(mountPath)) {
+        chrome.fileBrowserPrivate.getVolumeMetadata(mountPoints[i].sourceUrl,
+            this.DisplayFormattingTask3_.bind(this));
+        return;
+      }
+    }
+  };
+
+  FileManager.prototype.DisplayFormattingTask3_ = function(volumeMetadata) {

[rginda, 2011/08/10 23:08:09]

and onVolumeMetadataFound

[sidor.dev, 2011/08/10 23:51:21]

Done.

+    if (volumeMetadata.deviceType == "flash") {
+      var task = {
+        taskId: this.getExtensionId_() + '|format-device',
+        iconUrl: chrome.extension.getURL('images/filetype_generic.png'),
+        title: str('FORMAT_DEVICE')
+      };
+      this.renderTaskButton_(task);

[rginda, 2011/08/10 23:08:09]

You should probably omit the entries parameter to the outer function and instead
rely on this.selection.  Then at the point where the volume metadata is
returned, you can verify that the selection has not changed during the async
calls.  If it has, just bail out on the button rendering, since another
invocation will be taking care of it.

[sidor.dev, 2011/08/10 23:51:21]

Done.

+    }
+  };
+
   FileManager.prototype.getExtensionId_ = function() {
     return chrome.extension.getURL('').split('/')[2];
   };
 
   FileManager.prototype.onTaskButtonClicked_ = function(event) {
     chrome.fileBrowserPrivate.executeTask(event.srcElement.task.taskId,
                                           this.selection.urls);
   };
 
   /**
@@ skipping 44 matching lines @@
       chrome.fileBrowserPrivate.viewFiles(urls, id);
     } else if (id == 'mount-archive') {
       for (var index = 0; index < urls.length; ++index) {
         this.mountRequests_.push(urls[index]);
         chrome.fileBrowserPrivate.addMount(urls[index], 'file', {});
       }
     } else if (id == 'unmount-archive') {
       for (var index = 0; index < urls.length; ++index) {
         chrome.fileBrowserPrivate.removeMount(urls[index]);
       }
+    } else if (id == 'format-device') {
+      if (!confirm(str('FORMATTING_WARNING')))
+        return;
+      chrome.fileBrowserPrivate.formatDevice(urls[0]);
     }
   };
 
   /**
    * Determines whether unmount task should present for selected files.
    */
   FileManager.prototype.shouldShowUnmount_ = function(urls) {
     for (var index = 0; index < urls.length; ++index) {
       // Each url should be a mount point.
       var path = urls[index];
@@ skipping 1327 matching lines @@
 
     if (msg) {
       console.log('no no no');
       this.alert.show(msg, onAccept);
       return false;
     }
 
     return true;
   };
 })();