Adding a format device button to UI.

chrome/browser/extensions/extension_file_browser_private_api.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_file_browser_private_api.h"
 
 #include "base/base64.h"
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 633 matching lines @@
         BrowserThread::UI, FROM_HERE,
         NewRunnableMethod(function_,
             &ExecuteTasksFileBrowserFunction::ExecuteFailedOnUIThread));
   }
 
  private:
   // Checks legitimacy of file url and grants file RO access permissions from
   // handler (target) extension and its renderer process.
   bool SetupFileAccessPermissions(const GURL& origin_file_url,
      GURL* target_file_url, FilePath* file_path, bool* is_directory) {
-
     if (!extension_.get())
       return false;
 
     GURL file_origin_url;
     FilePath virtual_path;
     fileapi::FileSystemType type;
     if (!CrackFileSystemURL(origin_file_url, &file_origin_url, &type,
                             &virtual_path)) {
       return false;
     }
@@ skipping 615 matching lines @@
 }
 
 FormatDeviceFunction::~FormatDeviceFunction() {
 }
 
 bool FormatDeviceFunction::RunImpl() {
   if (args_->GetSize() != 1) {
     return false;
   }
 
-  std::string volume_mount_path;
-  if (!args_->GetString(0, &volume_mount_path)) {
+  std::string volume_file_url;
+  if (!args_->GetString(0, &volume_file_url)) {
     NOTREACHED();
     return false;
   }
 
+  UrlList file_paths;
+  file_paths.push_back(GURL(volume_file_url));
+
+  BrowserThread::PostTask(
+      BrowserThread::FILE, FROM_HERE,
+      NewRunnableMethod(this,
+          &FormatDeviceFunction::GetLocalPathsOnFileThread,
+          file_paths, reinterpret_cast<void*>(NULL)));
+  return true;
+}
+
+void FormatDeviceFunction::GetLocalPathsResponseOnUIThread(
+    const FilePathList& files, void* context) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  if (!files.size()) {

[tbarzic, 2011/08/10 21:04:56]

files.size() != 1 (you can format only one device)

[sidor.dev, 2011/08/10 22:38:17]

Done.

+    SendResponse(false);
+    return;
+  }
+  // FormatMountedDevice expects that path ends with '/'.
+  std::string mount_path = files[0].value().data();

[tbarzic, 2011/08/10 21:04:56]

files[0].value() should be sufficient..

You could also do this (it's up to you):
std::string mount_path(files[0].value());

[sidor.dev, 2011/08/10 22:38:17]

Done.

+  if (mount_path[mount_path.length()-1] != '/')

[tbarzic, 2011/08/10 21:04:56]

spaces around -

Also, I don't think you shouldn't add '/' at the end of the string..

[sidor.dev, 2011/08/10 22:38:17]

spaces done.

second issue - discussed.

+    mount_path.push_back('/');
+
 #ifdef OS_CHROMEOS
   chromeos::CrosLibrary::Get()->GetMountLibrary()->FormatMountedDevice(
-      volume_mount_path.c_str());
+      mount_path.c_str());
 #endif
 
   SendResponse(true);
-  return true;
 }
 
 GetVolumeMetadataFunction::GetVolumeMetadataFunction() {
 }
 
 GetVolumeMetadataFunction::~GetVolumeMetadataFunction() {
 }
 
 bool GetVolumeMetadataFunction::RunImpl() {
   if (args_->GetSize() != 1) {
@@ skipping 87 matching lines @@
   SET_STRING(IDS_FILE_BROWSER, DIMENSIONS_FORMAT);
 
   SET_STRING(IDS_FILE_BROWSER, EJECT_BUTTON);
   SET_STRING(IDS_FILE_BROWSER, IMAGE_DIMENSIONS);
   SET_STRING(IDS_FILE_BROWSER, VOLUME_LABEL);
   SET_STRING(IDS_FILE_BROWSER, READ_ONLY);
 
   SET_STRING(IDS_FILE_BROWSER, ARCHIVE_MOUNT_FAILED);
   SET_STRING(IDS_FILE_BROWSER, MOUNT_ARCHIVE);
   SET_STRING(IDS_FILE_BROWSER, UNMOUNT_ARCHIVE);
+  SET_STRING(IDS_FILE_BROWSER, FORMAT_DEVICE);
 
   SET_STRING(IDS_FILE_BROWSER, CONFIRM_OVERWRITE_FILE);
   SET_STRING(IDS_FILE_BROWSER, FILE_ALREADY_EXISTS);
   SET_STRING(IDS_FILE_BROWSER, DIRECTORY_ALREADY_EXISTS);
   SET_STRING(IDS_FILE_BROWSER, ERROR_RENAMING);
   SET_STRING(IDS_FILE_BROWSER, RENAME_PROMPT);
   SET_STRING(IDS_FILE_BROWSER, RENAME_BUTTON_LABEL);
 
   SET_STRING(IDS_FILE_BROWSER, ERROR_DELETING);
   SET_STRING(IDS_FILE_BROWSER, DELETE_BUTTON_LABEL);
@@ skipping 44 matching lines @@
   SET_STRING(IDS_FILE_BROWSER, NOTHING_SELECTED);
   SET_STRING(IDS_FILE_BROWSER, ONE_FILE_SELECTED);
   SET_STRING(IDS_FILE_BROWSER, ONE_DIRECTORY_SELECTED);
   SET_STRING(IDS_FILE_BROWSER, MANY_FILES_SELECTED);
   SET_STRING(IDS_FILE_BROWSER, MANY_DIRECTORIES_SELECTED);
   SET_STRING(IDS_FILE_BROWSER, MANY_ENTRIES_SELECTED);
 
   SET_STRING(IDS_FILE_BROWSER, PLAYBACK_ERROR);
 
   // MP3 metadata extractor plugin
-  SET_STRING(IDS_FILE_BROWSER, ID3_ALBUM); // TALB
-  SET_STRING(IDS_FILE_BROWSER, ID3_BPM); // TBPM
-  SET_STRING(IDS_FILE_BROWSER, ID3_COMPOSER); // TCOM
-  SET_STRING(IDS_FILE_BROWSER, ID3_COPYRIGHT_MESSAGE); // TCOP
-  SET_STRING(IDS_FILE_BROWSER, ID3_DATE); // TDAT
-  SET_STRING(IDS_FILE_BROWSER, ID3_PLAYLIST_DELAY); // TDLY
-  SET_STRING(IDS_FILE_BROWSER, ID3_ENCODED_BY); // TENC
-  SET_STRING(IDS_FILE_BROWSER, ID3_LYRICIST); // TEXT
-  SET_STRING(IDS_FILE_BROWSER, ID3_FILE_TYPE); // TFLT
-  SET_STRING(IDS_FILE_BROWSER, ID3_TIME); // TIME
-  SET_STRING(IDS_FILE_BROWSER, ID3_TITLE); // TIT2
-  SET_STRING(IDS_FILE_BROWSER, ID3_LENGTH); // TLEN
-  SET_STRING(IDS_FILE_BROWSER, ID3_FILE_OWNER); // TOWN
-  SET_STRING(IDS_FILE_BROWSER, ID3_LEAD_PERFORMER); // TPE1
-  SET_STRING(IDS_FILE_BROWSER, ID3_BAND); // TPE2
-  SET_STRING(IDS_FILE_BROWSER, ID3_TRACK_NUMBER); // TRCK
-  SET_STRING(IDS_FILE_BROWSER, ID3_YEAR); // TYER
-  SET_STRING(IDS_FILE_BROWSER, ID3_COPYRIGHT); // WCOP
-  SET_STRING(IDS_FILE_BROWSER, ID3_OFFICIAL_AUDIO_FILE_WEBPAGE); // WOAF
-  SET_STRING(IDS_FILE_BROWSER, ID3_OFFICIAL_ARTIST); // WOAR
-  SET_STRING(IDS_FILE_BROWSER, ID3_OFFICIAL_AUDIO_SOURCE_WEBPAGE); // WOAS
-  SET_STRING(IDS_FILE_BROWSER, ID3_PUBLISHERS_OFFICIAL_WEBPAGE); // WPUB
-  SET_STRING(IDS_FILE_BROWSER, ID3_USER_DEFINED_URL_LINK_FRAME); // WXXX
+  SET_STRING(IDS_FILE_BROWSER, ID3_ALBUM);  // TALB
+  SET_STRING(IDS_FILE_BROWSER, ID3_BPM);  // TBPM
+  SET_STRING(IDS_FILE_BROWSER, ID3_COMPOSER);  // TCOM
+  SET_STRING(IDS_FILE_BROWSER, ID3_COPYRIGHT_MESSAGE);  // TCOP
+  SET_STRING(IDS_FILE_BROWSER, ID3_DATE);  // TDAT
+  SET_STRING(IDS_FILE_BROWSER, ID3_PLAYLIST_DELAY);  // TDLY
+  SET_STRING(IDS_FILE_BROWSER, ID3_ENCODED_BY);  // TENC
+  SET_STRING(IDS_FILE_BROWSER, ID3_LYRICIST);  // TEXT
+  SET_STRING(IDS_FILE_BROWSER, ID3_FILE_TYPE);  // TFLT
+  SET_STRING(IDS_FILE_BROWSER, ID3_TIME);  // TIME
+  SET_STRING(IDS_FILE_BROWSER, ID3_TITLE);  // TIT2
+  SET_STRING(IDS_FILE_BROWSER, ID3_LENGTH);  // TLEN
+  SET_STRING(IDS_FILE_BROWSER, ID3_FILE_OWNER);  // TOWN
+  SET_STRING(IDS_FILE_BROWSER, ID3_LEAD_PERFORMER);  // TPE1
+  SET_STRING(IDS_FILE_BROWSER, ID3_BAND);  // TPE2
+  SET_STRING(IDS_FILE_BROWSER, ID3_TRACK_NUMBER);  // TRCK
+  SET_STRING(IDS_FILE_BROWSER, ID3_YEAR);  // TYER
+  SET_STRING(IDS_FILE_BROWSER, ID3_COPYRIGHT);  // WCOP
+  SET_STRING(IDS_FILE_BROWSER, ID3_OFFICIAL_AUDIO_FILE_WEBPAGE);  // WOAF
+  SET_STRING(IDS_FILE_BROWSER, ID3_OFFICIAL_ARTIST);  // WOAR
+  SET_STRING(IDS_FILE_BROWSER, ID3_OFFICIAL_AUDIO_SOURCE_WEBPAGE);  // WOAS
+  SET_STRING(IDS_FILE_BROWSER, ID3_PUBLISHERS_OFFICIAL_WEBPAGE);  // WPUB
+  SET_STRING(IDS_FILE_BROWSER, ID3_USER_DEFINED_URL_LINK_FRAME);  // WXXX
 
   SET_STRING(IDS_FILEBROWSER, ENQUEUE);
 #undef SET_STRING
 
   // TODO(serya): Create a new string in .grd file for this one in M13.
   dict->SetString("PREVIEW_IMAGE",
       l10n_util::GetStringUTF16(IDS_CERT_MANAGER_VIEW_CERT_BUTTON));
   dict->SetString("PLAY_MEDIA",
       l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLAY));
 
   return true;
 }