Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 7583036: Revert "net: Precede each CBC encrypted application data record with an empty one." (Closed)

Created:
9 years, 4 months ago by agl
Modified:
9 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert "net: Precede each CBC encrypted application data record with an empty one." This reverts commit r91768. BUG=91905 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95932

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -107 lines) Patch
M net/socket/ssl_client_socket_unittest.cc View 1 chunk +1 line, -1 line 2 comments Download
M net/third_party/nss/README.chromium View 1 chunk +0 lines, -5 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 chunk +0 lines, -2 lines 0 comments Download
D net/third_party/nss/patches/cbcrandomiv.patch View 1 chunk +0 lines, -73 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 5 chunks +2 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
agl
9 years, 4 months ago (2011-08-08 16:21:47 UTC) #1
wtc
LGTM. I have a question about the change to ssl_client_socket_unittest.cc below. http://codereview.chromium.org/7583036/diff/1/net/socket/ssl_client_socket_unittest.cc File net/socket/ssl_client_socket_unittest.cc (right): ...
9 years, 4 months ago (2011-08-08 17:06:05 UTC) #2
agl
http://codereview.chromium.org/7583036/diff/1/net/socket/ssl_client_socket_unittest.cc File net/socket/ssl_client_socket_unittest.cc (right): http://codereview.chromium.org/7583036/diff/1/net/socket/ssl_client_socket_unittest.cc#newcode405 net/socket/ssl_client_socket_unittest.cc:405: for (int i = 0; i < 3800; ++i) ...
9 years, 4 months ago (2011-08-08 17:29:02 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-09 01:55:05 UTC) #4
Change committed as 95932

Powered by Google App Engine
This is Rietveld 408576698