Issue 7583018: Add beforeUnload handler to confirm exit.

Issue 7583018: Add beforeUnload handler to confirm exit. (Closed)

Created:
9 years, 4 months ago by Jamie

Modified:
9 years, 4 months ago

Reviewers:
awong

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add beforeUnload handler to confirm exit. BUG=91835 TEST=Close the window at various points and check that you are prompted (or not) according to whether or not there is a connection pending or in progress. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95696

Patch Set 1 #

Patch Set 2 : Fixed client/host confusion. #

Total comments: 2

Patch Set 3 : Changed variable name. Fixed JSDoc syntax. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -3 lines)			Patch
remoting/webapp/me2mom/_locales/en/messages.json	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
remoting/webapp/me2mom/choice.html	View		1 chunk	+2 lines, -1 line	0 comments	Download
remoting/webapp/me2mom/remoting.js	View	1 2	3 chunks	+29 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jamie

Prompt before closing the chromoting tab if a connection is in progress. As well as ...

9 years, 4 months ago (2011-08-05 23:12:19 UTC) #1

awong

http://codereview.chromium.org/7583018/diff/2001/remoting/webapp/me2mom/remoting.js File remoting/webapp/me2mom/remoting.js (right): http://codereview.chromium.org/7583018/diff/2001/remoting/webapp/me2mom/remoting.js#newcode606 remoting/webapp/me2mom/remoting.js:606: var token = null; How about messageId instead of ...

9 years, 4 months ago (2011-08-05 23:17:25 UTC) #2

Jamie

9 years, 4 months ago (2011-08-05 23:36:51 UTC) #3

LGTM

(I just looked at the raw patch file)

Expand Messages | Collapse Messages