Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6283)

Unified Diff: chrome/browser/instant/instant_field_trial.h

Issue 7583012: Restrict Instant field trial to UMA opt-in users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed @jar's comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/instant/instant_field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_field_trial.h
diff --git a/chrome/browser/instant/instant_field_trial.h b/chrome/browser/instant/instant_field_trial.h
index fd808f60058ad29b0396e75f73296f070986104e..8c920398d7b63d6fa97e921b5a1563c1ab3a0780 100644
--- a/chrome/browser/instant/instant_field_trial.h
+++ b/chrome/browser/instant/instant_field_trial.h
@@ -12,7 +12,13 @@
class Profile;
// This class manages the Instant field trial. Each user is in exactly one of
-// two field trial groups: Control or Experiment.
+// three field trial groups: Inactive, Control or Experiment.
+// - Inactive users are those who have played with the Instant option in the
+// Preferences page, or those for whom group policy provides an override, or
+// those with an incognito profile, etc. The field trial is inactive for such
+// users, so their Instant preference setting is respected. The field trial is
+// also initially inactive (until activated in BrowserMain), so testing is not
+// affected by the field trial.
// - Control and Experiment are all the other users, i.e., those who have never
// touched the Preferences option. Some percentage of these users are chosen
// into the Experiment group and get Instant enabled automatically. The rest
@@ -20,13 +26,6 @@ class Profile;
// - Control and Experiment are further split into two subgroups each, in order
// to detect bias between them (when analyzing metrics). The subgroups are
// treated identically for all other purposes.
-//
-// There is a possibility that the field trial is not active.
-// - Inactive users are those who have played with the Instant option in the
-// Preferences page, or those for whom group policy provides an override, or
-// those with an incognito profile, etc. The field trial is inactive for such
-// users, so their Instant preference setting is respected. The field trial is
-// initially inactive so testing is not affected by the field trial.
class InstantFieldTrial {
public:
enum Group {
@@ -38,7 +37,7 @@ class InstantFieldTrial {
};
// Activate the field trial. Before this call, all calls to GetGroup will
- // return INACTIVE.
+ // return INACTIVE. *** MUST NOT BE CALLED MORE THAN ONCE. ***
static void Activate();
// Return the field trial group this profile belongs to.
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/instant/instant_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698