Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 7583005: When the download policy is specified but left empty revert to default download location. (Closed)

Created:
9 years, 4 months ago by pastarmovj
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

When the download policy is specified but left empty revert to default download location. If this is not done downloads go to crazy places like the chrome install dir or god knows where else. BUG=90722 TEST=Set the policy to empty string and observe downloads going to the default location instead. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/policy/configuration_policy_pref_store.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pastarmovj
Can you please have a look at that fix it is just minimal intrusion in ...
9 years, 4 months ago (2011-08-05 10:21:16 UTC) #1
Joao da Silva
LGTM! Please run through the try bots before committing.
9 years, 4 months ago (2011-08-05 12:13:55 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-26 09:39:33 UTC) #3
Change committed as 98411

Powered by Google App Engine
This is Rietveld 408576698