Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5818)

Unified Diff: chrome/browser/spellchecker/spellcheck_profile_unittest.cc

Issue 7583003: [Refactoring] Extracted SpellCheckProfile from ProfileImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: To commit Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_profile.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/spellchecker/spellcheck_profile_unittest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_profile_unittest.cc b/chrome/browser/spellchecker/spellcheck_profile_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1cc4266a916d5184f6b44060108eaf13539fa316
--- /dev/null
+++ b/chrome/browser/spellchecker/spellcheck_profile_unittest.cc
@@ -0,0 +1,156 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <vector>
+
+#include "chrome/browser/spellchecker/spellcheck_host.h"
+#include "chrome/browser/spellchecker/spellcheck_profile.h"
+#include "content/browser/browser_thread.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+class MockSpellCheckHost : public SpellCheckHost {
+ public:
+ MOCK_METHOD0(UnsetObserver, void());
+ MOCK_METHOD1(InitForRenderer, void(RenderProcessHost* process));
+ MOCK_METHOD1(AddWord, void(const std::string& word));
+ MOCK_CONST_METHOD0(GetDictionaryFile, const base::PlatformFile&());
+ MOCK_CONST_METHOD0(GetCustomWords, const std::vector<std::string>&());
+ MOCK_CONST_METHOD0(GetLastAddedFile, const std::string&());
+ MOCK_CONST_METHOD0(GetLanguage, const std::string&());
+ MOCK_CONST_METHOD0(IsUsingPlatformChecker, bool());
+ MOCK_CONST_METHOD0(GetMetrics, SpellCheckHostMetrics*());
+ MOCK_CONST_METHOD0(IsReady, bool());
+};
+
+class TestingSpellCheckProfile : public SpellCheckProfile {
+ public:
+ TestingSpellCheckProfile()
+ : create_host_calls_(0) {
+ }
+
+ virtual SpellCheckHost* CreateHost(
+ SpellCheckHostObserver* observer,
+ const std::string& language,
+ net::URLRequestContextGetter* request_context,
+ SpellCheckHostMetrics* metrics) {
+ create_host_calls_++;
+ return returning_from_create_.get();
+ }
+
+ virtual bool IsTesting() const {
+ return true;
+ }
+
+ bool IsCreatedHostReady() {
+ return GetHost() == returning_from_create_.get();
+ }
+
+ size_t create_host_calls_;
+ scoped_refptr<SpellCheckHost> returning_from_create_;
+};
+
+typedef SpellCheckProfile::ReinitializeResult ResultType;
+} // namespace
+
+class SpellCheckProfileTest : public testing::Test {
+ protected:
+ SpellCheckProfileTest()
+ : file_thread_(BrowserThread::FILE) {
+ }
+
+ // SpellCheckHost will be deleted on FILE thread.
+ BrowserThread file_thread_;
+};
+
+TEST_F(SpellCheckProfileTest, ReinitializeEnabled) {
+ scoped_refptr<MockSpellCheckHost> host(new MockSpellCheckHost());
+ TestingSpellCheckProfile target;
+ EXPECT_CALL(*host, UnsetObserver()).Times(1);
+ EXPECT_CALL(*host, IsReady()).WillRepeatedly(testing::Return(true));
+ target.returning_from_create_ = host.get();
+
+ // The first call should create host.
+ ResultType result1 = target.ReinitializeHost(false, true, "", NULL);
+ EXPECT_EQ(target.create_host_calls_, 1U);
+ EXPECT_EQ(result1, SpellCheckProfile::REINITIALIZE_CREATED_HOST);
+
+ // The second call should be ignored.
+ ResultType result2 = target.ReinitializeHost(false, true, "", NULL);
+ EXPECT_EQ(result2, SpellCheckProfile::REINITIALIZE_DID_NOTHING);
+ EXPECT_EQ(target.create_host_calls_, 1U);
+
+ // Host should become ready after the notification.
+ EXPECT_FALSE(target.IsCreatedHostReady());
+ target.SpellCheckHostInitialized();
+ EXPECT_TRUE(target.IsCreatedHostReady());
+}
+
+TEST_F(SpellCheckProfileTest, ReinitializeDisabled) {
+ scoped_refptr<MockSpellCheckHost> host(new MockSpellCheckHost());
+ TestingSpellCheckProfile target;
+ target.returning_from_create_ = host.get();
+
+ // If enabled is false, nothing should happen
+ ResultType result1 = target.ReinitializeHost(false, false, "", NULL);
+ EXPECT_EQ(target.create_host_calls_, 0U);
+ EXPECT_EQ(result1, SpellCheckProfile::REINITIALIZE_DID_NOTHING);
+
+ // Nothing should happen even if forced.
+ ResultType result2 = target.ReinitializeHost(true, false, "", NULL);
+ EXPECT_EQ(target.create_host_calls_, 0U);
+ EXPECT_EQ(result2, SpellCheckProfile::REINITIALIZE_DID_NOTHING);
+}
+
+TEST_F(SpellCheckProfileTest, ReinitializeRemove) {
+ scoped_refptr<MockSpellCheckHost> host(new MockSpellCheckHost());
+ EXPECT_CALL(*host, UnsetObserver()).Times(1);
+ EXPECT_CALL(*host, IsReady()).WillRepeatedly(testing::Return(true));
+
+ TestingSpellCheckProfile target;
+ target.returning_from_create_ = host.get();
+
+ // At first, create the host.
+ ResultType result1 = target.ReinitializeHost(false, true, "", NULL);
+ target.SpellCheckHostInitialized();
+ EXPECT_EQ(result1, SpellCheckProfile::REINITIALIZE_CREATED_HOST);
+ EXPECT_TRUE(target.IsCreatedHostReady());
+
+ // Then the host should be deleted if it's forced to be disabled.
+ ResultType result2 = target.ReinitializeHost(true, false, "", NULL);
+ target.SpellCheckHostInitialized();
+ EXPECT_EQ(result2, SpellCheckProfile::REINITIALIZE_REMOVED_HOST);
+ EXPECT_FALSE(target.IsCreatedHostReady());
+}
+
+TEST_F(SpellCheckProfileTest, ReinitializeRecreate) {
+ scoped_refptr<MockSpellCheckHost> host1(new MockSpellCheckHost());
+ EXPECT_CALL(*host1, UnsetObserver()).Times(1);
+ EXPECT_CALL(*host1, IsReady()).WillRepeatedly(testing::Return(true));
+
+ TestingSpellCheckProfile target;
+ target.returning_from_create_ = host1.get();
+
+ // At first, create the host.
+ ResultType result1 = target.ReinitializeHost(false, true, "", NULL);
+ target.SpellCheckHostInitialized();
+ EXPECT_EQ(target.create_host_calls_, 1U);
+ EXPECT_EQ(result1, SpellCheckProfile::REINITIALIZE_CREATED_HOST);
+ EXPECT_TRUE(target.IsCreatedHostReady());
+
+ // Then the host should be re-created if it's forced to recreate.
+ scoped_refptr<MockSpellCheckHost> host2(new MockSpellCheckHost());
+ EXPECT_CALL(*host2, UnsetObserver()).Times(1);
+ EXPECT_CALL(*host2, IsReady()).WillRepeatedly(testing::Return(true));
+ target.returning_from_create_ = host2.get();
+
+ ResultType result2 = target.ReinitializeHost(true, true, "", NULL);
+ target.SpellCheckHostInitialized();
+ EXPECT_EQ(target.create_host_calls_, 2U);
+ EXPECT_EQ(result2, SpellCheckProfile::REINITIALIZE_CREATED_HOST);
+ EXPECT_TRUE(target.IsCreatedHostReady());
+}
+
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_profile.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698