Issue 7582031: Product logo and name is the sole icon now

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7582031: Product logo and name is the sole icon now (Closed)

Created:
9 years, 4 months ago by glotov

Modified:
9 years, 4 months ago

Reviewers:
whywhat

CC:
chromium-reviews, arv (Not doing code reviews), rharrison, Nikita (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Product logo and name is the sole icon now BUG=chromium-os:17964 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95995

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -11 lines)			Patch
D	chrome/app/theme/chromium/product_logo_64.png	View	Binary file		0 comments	Download
A	chrome/app/theme/chromium/product_logo_name.png	View	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.css	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_installer.gypi	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

whywhat

9 years, 4 months ago (2011-08-08 15:20:02 UTC) #2

LGTM

http://codereview.chromium.org/7582031/diff/1/chrome/chrome_installer.gypi
File chrome/chrome_installer.gypi (right):

http://codereview.chromium.org/7582031/diff/1/chrome/chrome_installer.gypi#ne...
chrome/chrome_installer.gypi:485: '<(branding_dir)/product_logo_name.png',
Are you sure nobody else uses this logo?

Expand Messages | Collapse Messages