Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 7582024: chromeos: Look for "Master" or "Digital" mixer elements. (Closed)

Created:
9 years, 4 months ago by Daniel Erat
Modified:
9 years, 4 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Look for "Master" or "Digital" mixer elements. This removes the code to control "Headphone" and "Speaker" elements simultaneously for ARM, and makes us instead just look for "Master" (x86) or "Digital" (ARM). BUG=chromium-os:18578 TEST=manual: still works on x86 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96402

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -36 lines) Patch
M chrome/browser/chromeos/audio_mixer_alsa.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/audio_mixer_alsa.cc View 6 chunks +18 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
9 years, 4 months ago (2011-08-08 17:06:25 UTC) #1
Daniel Erat
ping -- you wanted this change, right?
9 years, 4 months ago (2011-08-10 01:29:59 UTC) #2
thutt
LGTM
9 years, 4 months ago (2011-08-10 20:35:25 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-10 22:28:48 UTC) #4
No LGTM from valid reviewers yet.

Powered by Google App Engine
This is Rietveld 408576698