Issue 7582021: Leaks in BrowserAccessibilityManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7582021: Leaks in BrowserAccessibilityManager (Closed)

Created:
9 years, 4 months ago by dhollowa

Modified:
9 years, 4 months ago

Reviewers:
David Tseng

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Leaks in BrowserAccessibilityManager Suppresses leaks introduced with r95572 related to BrowserAccessibilityManager. More suppressions. BUG=91845 TEST=Valgrind and HeapCheck bots turn green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95683

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

David Tseng

9 years, 4 months ago (2011-08-05 23:25:38 UTC) #2

LGTM

On 8/5/11, dhollowa@chromium.org <dhollowa@chromium.org> wrote:
> Reviewers: David Tseng,
>
> Description:
> Leaks in BrowserAccessibilityManager
>
> Suppresses leaks introduced with r95572 related to
> BrowserAccessibilityManager.
> More suppressions.
>
> BUG=91845
> TEST=Valgrind and HeapCheck bots turn green.
>
>
> Please review this at http://codereview.chromium.org/7582021/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>    M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
b141428f3d9e5d6812460717472aa6f32a265862..51fce686f5136b398207c0f13e034843b390fb08
>
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -5401,7 +5401,7 @@
>      fun:_ZN42BrowsingDataQuotaHelperTest_FetchData_Test8TestBodyEv
>   }
>   {
> -   bug_91845
> +   bug_91845_a
>      Memcheck:Leak
>      fun:_Znw*
>      ...
> @@ -5409,6 +5409,14 @@
>      ...
>
>
fun:_ZN60BrowserAccessibilityManagerTest_TestCreateEmptyDocument_Test8TestBodyEv
>   }
> +{
> +   bug_91845_b
> +   Memcheck:Leak
> +   fun:_Znw*
> +
>
fun:_ZN27BrowserAccessibilityManager6CreateEP10_GtkWidgetRKN11webkit_glue16WebAccessibilityEP28BrowserAccessibilityDelegateP27BrowserAccessibilityFactory
> +
>
fun:_ZN27BrowserAccessibilityManager19CreateEmptyDocumentEP10_GtkWidgetN11webkit_glue16WebAccessibility5StateEP28BrowserAccessibilityDelegateP27BrowserAccessibilityFactory
> +
>
fun:_ZN60BrowserAccessibilityManagerTest_TestCreateEmptyDocument_Test8TestBodyEv
> +}
>
>   #-----------------------------------------------------------------------
>   # These only occur on our Google workstations
>
>
>

Expand Messages | Collapse Messages