Issue 7582017: Do not display warnings for file:/// extension permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7582017: Do not display warnings for file:/// extension permissions. (Closed)

Created:
9 years, 4 months ago by jstritar

Modified:
9 years, 4 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Do not display warnings for file:/// extension permissions. BUG=none TEST=ExtensionPermissionSetTest.GetDistinctHostsForDisplay Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95817

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -5 lines)			Patch
M	chrome/common/extensions/extension_permission_set.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension_permission_set.cc	View	1	5 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/extension_permission_set_unittest.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

9 years, 4 months ago (2011-08-05 22:56:35 UTC) #2

LGTM

http://codereview.chromium.org/7582017/diff/1/chrome/common/extensions/extens...
File chrome/common/extensions/extension_permission_set.cc (right):

http://codereview.chromium.org/7582017/diff/1/chrome/common/extensions/extens...
chrome/common/extensions/extension_permission_set.cc:700: if
(exclude_file_scheme && i->scheme() == "file")
nit: change "file" to chrome::kFileScheme, save a few bytes (and the lives of
some kittens brettw won't have to kill)

http://codereview.chromium.org/7582017/diff/1/chrome/common/extensions/extens...
File chrome/common/extensions/extension_permission_set_unittest.cc (right):

http://codereview.chromium.org/7582017/diff/1/chrome/common/extensions/extens...
chrome/common/extensions/extension_permission_set_unittest.cc:878:
SCOPED_TRACE("file urls");
Whoa, SCOPED_TRACE is awesome! I had never heard of it before, and just
yesterday was writing a CL where I wished we had something like this.

Expand Messages | Collapse Messages