Index: Source/WebCore/ChangeLog |
=================================================================== |
--- Source/WebCore/ChangeLog (revision 92484) |
+++ Source/WebCore/ChangeLog (working copy) |
@@ -1,35 +1,1790 @@ |
-2011-08-02 Levi Weintraub <leviw@chromium.org> |
+2011-08-03 Sailesh Agrawal <sail@chromium.org> |
- REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe) |
- https://bugs.webkit.org/show_bug.cgi?id=64974 |
+ Chromium Mac: Make sure scrollbars flash when web page loads |
+ https://bugs.webkit.org/show_bug.cgi?id=65586 |
+ On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars. |
+ |
Reviewed by James Robinson. |
- Rolling back r87526 for Chrome 14. |
+ * platform/chromium/ScrollAnimatorChromiumMac.mm: |
+ (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired): |
- * platform/Length.h: |
- (WebCore::Length::isIntrinsicOrAuto): |
- * rendering/RenderPart.cpp: |
- (WebCore::RenderPart::embeddedContentBox): |
+2011-08-03 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Remove LegacyDefaultOptionalArguments flag from navigator IDL files |
+ https://bugs.webkit.org/show_bug.cgi?id=65370 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ * page/Navigator.idl: |
+ * page/NavigatorUserMediaErrorCallback.idl: |
+ * page/NavigatorUserMediaSuccessCallback.idl: |
+ |
+2011-08-03 Anders Carlsson <andersca@apple.com> |
+ |
+ webarchive/loading/missing-data.html is failing on Mac |
+ https://bugs.webkit.org/show_bug.cgi?id=63507 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ When loading a main resource from a web archive, make sure that the working URL is actually |
+ the URL of the resource, and not the URL of the web archive itself. |
+ |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::receivedFirstData): |
+ |
+2011-08-03 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl |
+ https://bugs.webkit.org/show_bug.cgi?id=65353 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ No new tests, all existing tests pass. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ (GenerateImplementation): |
+ * bindings/scripts/CodeGeneratorV8.pm: |
+ (GenerateFunctionCallback): |
+ * page/DOMWindow.idl: |
+ |
+2011-08-03 Jeff Miller <jeffm@apple.com> |
+ |
+ Fix Chromimum and Qt builds after r92308. |
+ |
+ * config.h: Don't try to include WebCoreHeaderDetection.h for Chromimum and Qt. |
+ |
+2011-08-03 Jeff Miller <jeffm@apple.com> |
+ |
+ Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF |
+ https://bugs.webkit.org/show_bug.cgi?id=65634 |
+ |
+ AVFoundation support on Windows will (eventually) be predicated on the |
+ availability of AVFoundationCF headers and libraries in the WebKit Support |
+ Libraries, so we test for the existence of one of the header files (AVCFBase.h) |
+ to determine whether to AVCF is available. |
+ |
+ For now, even if AVFoundationCF is available, leave WTF_USE_AVFOUNDATION off, since |
+ it's not ready to be turned on yet (which is covered by http://webkit.org/b/65400). |
+ |
+ Ideally, we would generate WebCoreHeaderDetection.h on all platforms so we could |
+ include it unconditionally in WebCore's config.h, but unfortunately the Mac-only file |
+ ExportFileGenerator.cpp depends on WTF_USE_AVFOUNDATION being set correctly, and since this |
+ .cpp file is also generated it doesn't have access to WebCoreHeaderDetection.h. |
+ |
+ Reviewed by Adam Roben. |
+ |
+ No change in functionality, so new tests. |
+ |
+ * DerivedSources.make: Add rule to generate WebCoreHeaderDetection.h to set HAVE_AVCF on Windows. |
+ * config.h: Include WebCoreHeaderDetection.h on Windows, check for HAVE(AVCF) but always leave WTF_USE_AVFOUNDATION off on Windows for now. |
+ |
+2011-08-03 Tommy Widenflycht <tommyw@google.com> |
+ |
+ MediaStream API: Implement PeerConnection and SignalingCallback |
+ https://bugs.webkit.org/show_bug.cgi?id=65101 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ LayoutTests will be provided by a follow-up CL, see <https://bugs.webkit.org/show_bug.cgi?id=56587>. |
+ |
+ * CMakeLists.txt: |
+ * CodeGenerators.pri: |
+ * DerivedSources.cpp: |
+ * DerivedSources.make: |
+ * GNUmakefile.am: |
+ * GNUmakefile.list.am: |
+ * UseJSC.cmake: |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/generic/RuntimeEnabledFeatures.h: |
+ (WebCore::RuntimeEnabledFeatures::peerConnectionEnabled): |
+ * bindings/js/JSBindingsAllInOne.cpp: |
+ * bindings/js/JSPeerConnectionCustom.cpp: Copied from Source/WebCore/page/MediaStreamClient.h. |
+ (WebCore::JSPeerConnectionConstructor::constructJSPeerConnection): |
+ * bindings/v8/V8DOMWrapper.cpp: |
+ (WebCore::V8DOMWrapper::convertEventTargetToV8Object): |
+ * bindings/v8/custom/V8PeerConnectionCustom.cpp: Added. |
+ (WebCore::V8PeerConnection::constructorCallback): |
+ * dom/DispatchTask.h: Added. |
+ (WebCore::SimpleDispatchTask::create): |
+ (WebCore::SimpleDispatchTask::performTask): |
+ (WebCore::SimpleDispatchTask::SimpleDispatchTask): |
+ (WebCore::DispatchTask::create): |
+ (WebCore::DispatchTask::performTask): |
+ (WebCore::DispatchTask::DispatchTask): |
+ * dom/EventNames.h: |
+ * dom/EventTarget.cpp: |
+ (WebCore::EventTarget::toPeerConnection): |
+ * dom/EventTarget.h: |
+ * p2p/PeerConnection.cpp: Added. |
+ (WebCore::PeerConnection::create): |
+ (WebCore::PeerConnection::PeerConnection): |
+ (WebCore::PeerConnection::init): |
+ (WebCore::PeerConnection::~PeerConnection): |
+ (WebCore::PeerConnection::localStreams): |
+ (WebCore::PeerConnection::remoteStreams): |
+ (WebCore::PeerConnection::processSignalingMessage): |
+ (WebCore::PeerConnection::send): |
+ (WebCore::PeerConnection::addStream): |
+ (WebCore::PeerConnection::removeStream): |
+ (WebCore::PeerConnection::close): |
+ (WebCore::PeerConnection::onNegotiationStarted): |
+ (WebCore::PeerConnection::onNegotiationDone): |
+ (WebCore::PeerConnection::streamAdded): |
+ (WebCore::PeerConnection::streamRemoved): |
+ (WebCore::PeerConnection::onMessage): |
+ (WebCore::PeerConnection::onSignalingMessage): |
+ (WebCore::PeerConnection::toPeerConnection): |
+ (WebCore::PeerConnection::scriptExecutionContext): |
+ (WebCore::PeerConnection::eventTargetData): |
+ (WebCore::PeerConnection::ensureEventTargetData): |
+ (WebCore::PeerConnection::postMessageEvent): |
+ (WebCore::PeerConnection::postSignalingEvent): |
+ (WebCore::PeerConnection::postStreamAddedEvent): |
+ (WebCore::PeerConnection::postStreamRemovedEvent): |
+ (WebCore::PeerConnection::postSimpleEvent): |
+ (WebCore::PeerConnection::postStartNegotiationTask): |
+ (WebCore::PeerConnection::dispatchMessageEvent): |
+ (WebCore::PeerConnection::dispatchSignalingEvent): |
+ (WebCore::PeerConnection::dispatchStreamEvent): |
+ (WebCore::PeerConnection::dispatchSimpleEvent): |
+ (WebCore::PeerConnection::dispatchStartNegotiationTask): |
+ * p2p/PeerConnection.h: Added. |
+ (WebCore::PeerConnection::readyState): |
+ (WebCore::PeerConnection::refEventTarget): |
+ (WebCore::PeerConnection::derefEventTarget): |
+ * p2p/PeerConnection.idl: Added. |
+ * p2p/SignalingCallback.h: Copied from Source/WebCore/page/MediaStreamClient.h. |
+ (WebCore::SignalingCallback::~SignalingCallback): |
+ * p2p/SignalingCallback.idl: Added. |
+ * page/DOMWindow.idl: |
+ * page/MediaStreamClient.h: |
+ * page/MediaStreamController.cpp: |
+ (WebCore::MediaStreamController::MediaStreamController): |
+ (WebCore::MediaStreamController::unregisterFrameController): |
+ (WebCore::MediaStreamController::onSignalingMessage): |
+ (WebCore::MediaStreamController::frameToPagePeerConnectionId): |
+ (WebCore::MediaStreamController::processSignalingMessage): |
+ (WebCore::MediaStreamController::message): |
+ (WebCore::MediaStreamController::onMessage): |
+ (WebCore::MediaStreamController::addStream): |
+ (WebCore::MediaStreamController::onAddStream): |
+ (WebCore::MediaStreamController::removeStream): |
+ (WebCore::MediaStreamController::onRemoveStream): |
+ (WebCore::MediaStreamController::newPeerConnection): |
+ (WebCore::MediaStreamController::closePeerConnection): |
+ (WebCore::MediaStreamController::startNegotiation): |
+ (WebCore::MediaStreamController::onNegotiationStarted): |
+ (WebCore::MediaStreamController::onNegotiationDone): |
+ * page/MediaStreamController.h: |
+ * page/MediaStreamFrameController.cpp: |
+ (WebCore::MediaStreamFrameController::Request::isSignalingRequest): |
+ (WebCore::MediaStreamFrameController::createPeerConnection): |
+ (WebCore::MediaStreamFrameController::newPeerConnection): |
+ (WebCore::MediaStreamFrameController::closePeerConnection): |
+ (WebCore::MediaStreamFrameController::startNegotiation): |
+ (WebCore::MediaStreamFrameController::processSignalingMessage): |
+ (WebCore::MediaStreamFrameController::message): |
+ (WebCore::MediaStreamFrameController::addStream): |
+ (WebCore::MediaStreamFrameController::removeStream): |
+ (WebCore::MediaStreamFrameController::onMessage): |
+ (WebCore::MediaStreamFrameController::onAddStream): |
+ (WebCore::MediaStreamFrameController::onRemoveStream): |
+ (WebCore::MediaStreamFrameController::onSignalingMessage): |
+ (WebCore::MediaStreamFrameController::onNegotiationStarted): |
+ (WebCore::MediaStreamFrameController::onNegotiationDone): |
+ * page/MediaStreamFrameController.h: |
+ (WebCore::MediaStreamFrameController::ClientBase::isPeerConnection): |
+ (WebCore::MediaStreamFrameController::PeerConnectionClient::PeerConnectionClient): |
+ (WebCore::MediaStreamFrameController::PeerConnectionClient::~PeerConnectionClient): |
+ (WebCore::MediaStreamFrameController::PeerConnectionClient::isPeerConnection): |
+ |
+2011-08-03 Joseph Pecoraro <joepeck@webkit.org> |
+ |
+ Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting |
+ https://bugs.webkit.org/show_bug.cgi?id=65582 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Remove stale code. WebInspector.settings uses localStorage and |
+ handles the "debuggerEnabled" state. So remove the only remaining |
+ usage of load/saveSessionSetting. |
+ |
+ * inspector/InspectorFrontendClient.h: |
+ * inspector/InspectorFrontendHost.cpp: |
+ * inspector/InspectorFrontendHost.h: |
+ * inspector/InspectorFrontendHost.idl: |
+ * inspector/front-end/InspectorFrontendHostStub.js: |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled): |
+ |
+2011-08-03 Adam Barth <abarth@webkit.org> |
+ |
+ Crash in DocumentWriter::endIfNotLoadingMainResource |
+ https://bugs.webkit.org/show_bug.cgi?id=65581 |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ This function is poorly designed because isLoadingMainResource is a |
+ poor proxy for determing whether to flush/finish the parser. Really, |
+ we should change how loads complete to match the model in HTML5, but |
+ that's pretty tricky. In the meantime, this null check fixes the |
+ crash. |
+ |
+ I'm sure there's another bug on file about this crash, but we've never |
+ been able to reproduce it. Thanks to Berend-Jan Wever for the test |
+ case! |
+ |
+ Test: fast/loader/reload-zero-byte-plugin.html |
+ |
+ * loader/DocumentWriter.cpp: |
+ (WebCore::DocumentWriter::endIfNotLoadingMainResource): |
+ |
+2011-08-03 Anders Carlsson <andersca@apple.com> |
+ |
+ WebCore images backing CG patterns should be released on the main thread |
+ https://bugs.webkit.org/show_bug.cgi?id=65630 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ * platform/graphics/cg/PatternCG.cpp: |
+ (WebCore::patternReleaseOnMainThreadCallback): |
+ Deref the image. |
+ |
+ (WebCore::patternReleaseCallback): |
+ Call callOnMainThread. |
+ |
+2011-08-03 Luke Macpherson <macpherson@chromium.org> |
+ |
+ Use appropriate macro for CSSPropertyImageRendering. |
+ https://bugs.webkit.org/show_bug.cgi?id=65594 |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ No new tests / trivial code cleanup only. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro. |
+ |
+2011-08-03 Dan Bernstein <mitz@apple.com> |
+ |
+ FontCache::getFontData() does not set the familyIndex to cAllFamiliesScanned if the last font is a custom font |
+ https://bugs.webkit.org/show_bug.cgi?id=65597 |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ No test added because behavior is unchanged, but this saves a call to getFontData(). |
+ |
+ * platform/graphics/FontCache.cpp: |
+ (WebCore::FontCache::getFontData): Eliminated early return inside the loop, allowing execution |
+ to continue and familyIndex to be set. |
+ |
+2011-08-03 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Add RenderedPosition |
+ https://bugs.webkit.org/show_bug.cgi?id=65221 |
+ |
+ Reviewed by Hajime Morita. |
+ |
+ Add the skeleton for RenderedPosition and use it in rootBoxForLine. |
+ |
+ * CMakeLists.txt: |
+ * GNUmakefile.list.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * editing/EditingAllInOne.cpp: |
+ * editing/RenderedPosition.cpp: Added. |
+ (WebCore::RenderedPosition::RenderedPosition): |
+ * editing/RenderedPosition.h: Added. |
+ (WebCore::RenderedPosition::isNull): |
+ (WebCore::RenderedPosition::rootBox): |
+ (WebCore::RenderedPosition::RenderedPosition): |
+ * editing/visible_units.cpp: |
+ (WebCore::startPositionForLine): |
+ (WebCore::endPositionForLine): |
+ (WebCore::logicalStartPositionForLine): |
+ (WebCore::logicalEndPositionForLine): |
+ |
+2011-08-03 Roland Steiner <rolandsteiner@chromium.org> |
+ |
+ [V8] V8CSSRuleCustom.cpp: not all enum values are listed in switch statement |
+ https://bugs.webkit.org/show_bug.cgi?id=65598 |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ Added UNKNOWN_RULE to the switch statement. |
+ |
+ No new tests. (No semantic change) |
+ |
+ * bindings/v8/custom/V8CSSRuleCustom.cpp: |
+ (WebCore::toV8): |
+ |
+2011-08-03 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: [Timeline] Hover on paint events and see rect outline around that area. |
+ https://bugs.webkit.org/show_bug.cgi?id=65510 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ * WebCore.exp.in: |
+ * WebCore.order: |
+ * inspector/DOMNodeHighlighter.cpp: |
+ (WebCore::DOMNodeHighlighter::drawRectHighlight): |
+ * inspector/DOMNodeHighlighter.h: |
+ * inspector/Inspector.json: |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::drawHighlight): |
+ * inspector/InspectorController.h: |
+ * inspector/InspectorDOMAgent.cpp: |
+ (WebCore::InspectorDOMAgent::highlightRect): |
+ (WebCore::InspectorDOMAgent::hideHighlight): |
+ (WebCore::InspectorDOMAgent::drawHighlight): |
+ * inspector/InspectorDOMAgent.h: |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.FrameTreeElement.prototype.onselect): |
+ (WebInspector.FrameTreeElement.prototype.set hovered): |
+ * inspector/front-end/TimelinePanel.js: |
+ (WebInspector.TimelinePanel): |
+ (WebInspector.TimelinePanel.prototype._mouseOut): |
+ (WebInspector.TimelinePanel.prototype._mouseMove): |
+ (WebInspector.TimelinePanel.prototype._highlightRect): |
+ (WebInspector.TimelinePanel.prototype._hideRectHighlight): |
+ * inspector/front-end/inspector.js: |
+ (WebInspector.highlightDOMNode): |
+ |
+2011-08-03 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: make text in popover selectable + make popover re-appear faster. |
+ https://bugs.webkit.org/show_bug.cgi?id=65603 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ * inspector/front-end/Popover.js: |
+ (WebInspector.PopoverHelper.prototype.setTimeout): |
+ (WebInspector.PopoverHelper.prototype._mouseMove): |
+ (WebInspector.PopoverHelper.prototype._handleMouseAction): |
+ * inspector/front-end/popover.css: |
+ (.popover .content): |
+ |
+2011-08-03 Vsevolod Vlasov <vsevik@chromium.org> |
+ |
+ Web Inspector: Console scroll position should be saved when switching panels. |
+ https://bugs.webkit.org/show_bug.cgi?id=65607 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * inspector/front-end/ConsoleView.js: |
+ (WebInspector.ConsoleView.prototype._formatAsArrayEntry): |
+ (WebInspector.ConsoleView.prototype.get scrollLeft): |
+ (WebInspector.ConsoleView.prototype.set scrollLeft): |
+ (WebInspector.ConsoleView.prototype.get scrollTop): |
+ (WebInspector.ConsoleView.prototype.set scrollTop): |
+ * inspector/front-end/Drawer.js: |
+ (WebInspector.Drawer.prototype.show): |
+ (WebInspector.Drawer.prototype._endStatusBarDragging): |
+ (WebInspector.Drawer.prototype.get scrollLeft): |
+ (WebInspector.Drawer.prototype.set scrollLeft): |
+ (WebInspector.Drawer.prototype.get scrollTop): |
+ (WebInspector.Drawer.prototype.set scrollTop): |
+ |
+2011-08-03 Philippe Normand <pnormand@igalia.com> |
+ |
+ libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed |
+ https://bugs.webkit.org/show_bug.cgi?id=64263 |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ Avoid any operation on not yet started messages and completed messages. |
+ |
+ * platform/network/ResourceHandleInternal.h: |
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal): |
+ * platform/network/soup/ResourceHandleSoup.cpp: |
+ (WebCore::finishedCallback): |
+ (WebCore::startHTTPRequest): |
+ (WebCore::ResourceHandle::platformSetDefersLoading): |
+ |
+2011-08-03 Jeremy Moskovich <jeremy@chromium.org> |
+ |
+ [Chromium] Fix OOP font loading to work on 10.6.6 and above. |
+ https://bugs.webkit.org/show_bug.cgi?id=65543 |
+ |
+ In 10.6.6 the function used to get the unique ID for an NSFont in the |
+ renderer was changed so it fails in the sandbox (it now tries to access |
+ the on-disk font file). In order to work around this, we get the font |
+ ID from the browser process. |
+ |
+ To speed things up, we introduce 2 levels of caching in WebKit. A font |
+ name cache where we can perform a quick lookup without the need for the |
+ font id and a font id cache which we can only lookup in after getting |
+ the unique ID from the browser process. |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ No new tests since this is not readily testable. |
+ |
+ * platform/chromium/PlatformBridge.h: |
+ * platform/graphics/chromium/CrossProcessFontLoading.h: |
+ * platform/graphics/chromium/CrossProcessFontLoading.mm: |
+ (WebCore::MemoryActivatedFont::create): |
+ (WebCore::MemoryActivatedFont::MemoryActivatedFont): |
+ (WebCore::MemoryActivatedFont::~MemoryActivatedFont): |
+ |
+2011-08-03 Hayato Ito <hayato@chromium.org> |
+ |
+ Make EventDispatchMediator RefCounted. |
+ https://bugs.webkit.org/show_bug.cgi?id=65529 |
+ |
+ Reviewed by Hajime Morita. |
+ |
+ Make EventDispatchMediator RefCounted so that it can be enqueued into a |
+ ScopedEventQueue and called later. |
+ A necessary change for ScopedEventQueue should be addressed in another patch. |
+ |
+ This is a minor update of r92256, which failed on chromium win builds. |
+ |
+ No changes to functionality so no new tests. |
+ |
+ * dom/Event.cpp: |
+ (WebCore::EventDispatchMediator::create): |
+ * dom/Event.h: |
+ * dom/EventDispatcher.cpp: |
+ (WebCore::EventDispatcher::dispatchEvent): |
+ * dom/EventDispatcher.h: |
+ * dom/KeyboardEvent.cpp: |
+ (WebCore::KeyboardEventDispatchMediator::create): |
+ * dom/KeyboardEvent.h: |
+ * dom/MouseEvent.cpp: |
+ (WebCore::MouseEventDispatchMediator::create): |
+ * dom/MouseEvent.h: |
+ * dom/Node.cpp: |
+ (WebCore::Node::dispatchEvent): |
+ (WebCore::Node::dispatchKeyEvent): |
+ (WebCore::Node::dispatchMouseEvent): |
+ (WebCore::Node::dispatchWheelEvent): |
+ * dom/WheelEvent.cpp: |
+ (WebCore::WheelEventDispatchMediator::create): |
+ * dom/WheelEvent.h: |
+ |
+2011-08-03 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Web Inspector: remove Node parameter from the InspectorClient::highlight |
+ https://bugs.webkit.org/show_bug.cgi?id=65549 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ * inspector/InspectorClient.h: |
+ * inspector/InspectorDOMAgent.cpp: |
+ (WebCore::InspectorDOMAgent::highlight): |
+ * loader/EmptyClients.h: |
+ (WebCore::EmptyInspectorClient::highlight): |
+ |
+2011-08-03 Antti Koivisto <antti@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=65599 |
+ Image loads should trigger didFirstVisuallyNonEmptyLayout more easily |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Tweak the heuristic pixel count so logo-sized images trigger didFirstVisuallyNonEmptyLayout. |
+ |
+ * page/FrameView.h: |
+ (WebCore::FrameView::incrementVisuallyNonEmptyPixelCount): |
+ |
+2011-08-03 Takashi Toyoshima <toyoshim@chromium.org> |
+ |
+ WebSocket: Could not handle zero length text frame. |
+ https://bugs.webkit.org/show_bug.cgi?id=65592 |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ Test: http/tests/websocket/tests/hybi/zero-length-text.html |
+ |
+ * websockets/WebSocketChannel.cpp: |
+ (WebCore::WebSocketChannel::processFrame): |
+ |
+2011-08-02 Pratik Solanki <psolanki@apple.com> |
+ |
+ Crash in ResourceResponse::platformCompare() with USE(CFNETWORK) |
+ https://bugs.webkit.org/show_bug.cgi?id=65584 |
+ |
+ Reviewed by David Kilzer. |
+ |
+ * platform/network/cf/ResourceResponseCFNet.cpp: |
+ (WebCore::ResourceResponse::platformCompare): Don't call CFEqual with 0 as an argument. |
+ |
+2011-08-02 Takashi Toyoshima <toyoshim@chromium.org> |
+ |
+ WebSocket: Should be closed by receiving invalid continuation frame. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=65527 |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ Test: http/tests/websocket/tests/hybi/invalid-continuation.html |
+ |
+ * websockets/WebSocketChannel.cpp: |
+ (WebCore::WebSocketChannel::processFrame): |
+ |
+2011-08-02 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r92256. |
+ http://trac.webkit.org/changeset/92256 |
+ https://bugs.webkit.org/show_bug.cgi?id=65593 |
+ |
+ Causing tons of crashes on the chromium win bots (Requested by |
+ jamesr on #webkit). |
+ |
+ * dom/Event.cpp: |
+ * dom/Event.h: |
+ * dom/EventDispatcher.cpp: |
+ (WebCore::EventDispatcher::dispatchEvent): |
+ * dom/EventDispatcher.h: |
+ * dom/KeyboardEvent.cpp: |
+ * dom/KeyboardEvent.h: |
+ * dom/MouseEvent.cpp: |
+ * dom/MouseEvent.h: |
+ * dom/Node.cpp: |
+ (WebCore::Node::dispatchEvent): |
+ (WebCore::Node::dispatchKeyEvent): |
+ (WebCore::Node::dispatchMouseEvent): |
+ (WebCore::Node::dispatchWheelEvent): |
+ * dom/WheelEvent.cpp: |
+ * dom/WheelEvent.h: |
+ |
+2011-08-02 Hayato Ito <hayato@chromium.org> |
+ |
+ Make EventDispatchMediator RefCounted. |
+ https://bugs.webkit.org/show_bug.cgi?id=65529 |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ Make EventDispatchMediator RefCounted so that it can be enqueued into a |
+ ScopedEventQueue and called later. |
+ A necessary change for ScopedEventQueue should be addressed in another patch. |
+ |
+ No changes to functionality so no new tests. |
+ |
+ * dom/Event.cpp: |
+ (WebCore::EventDispatchMediator::create): |
+ * dom/Event.h: |
+ * dom/EventDispatcher.cpp: |
+ (WebCore::EventDispatcher::dispatchEvent): |
+ * dom/EventDispatcher.h: |
+ * dom/KeyboardEvent.cpp: |
+ (WebCore::KeyboardEventDispatchMediator::create): |
+ * dom/KeyboardEvent.h: |
+ * dom/MouseEvent.cpp: |
+ (WebCore::MouseEventDispatchMediator::create): |
+ * dom/MouseEvent.h: |
+ * dom/Node.cpp: |
+ (WebCore::Node::dispatchEvent): |
+ (WebCore::Node::dispatchKeyEvent): |
+ (WebCore::Node::dispatchMouseEvent): |
+ (WebCore::Node::dispatchWheelEvent): |
+ * dom/WheelEvent.cpp: |
+ (WebCore::WheelEventDispatchMediator::create): |
+ * dom/WheelEvent.h: |
+ |
+2011-08-02 David Reveman <reveman@chromium.org> |
+ |
+ [Chromium] Use edge-distance method for layer anti-aliasing. |
+ https://bugs.webkit.org/show_bug.cgi?id=64942 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Use an edge distance based method instead of the current linear |
+ filtering method for producing anti-aliased edges on 3D transformed |
+ layers. This removes the outer border handling from TilingData as |
+ it's no longer needed for anti-aliasing. |
+ |
+ Tests: platform/chromium/compositing/tiny-layer-rotated.html (existing) |
+ platform/chromium/compositing/huge-layer-rotated.html (existing) |
+ compositing/images/content-image-change.html (existing) |
+ TilingDataTest in webkit_unit_tests |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::screenMatrix): |
+ (WebCore::LayerRendererChromium::drawLayers): |
+ (WebCore::LayerRendererChromium::setDrawViewportRect): |
+ (WebCore::LayerRendererChromium::tilerProgramAA): |
+ (WebCore::LayerRendererChromium::tilerProgramSwizzleAA): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ (WebCore::LayerRendererChromium::windowMatrix): |
+ * platform/graphics/chromium/LayerTilerChromium.cpp: |
+ (WebCore::LayerTilerChromium::setTileSize): |
+ (WebCore::LayerTilerChromium::tileLayerRect): |
+ (WebCore::LayerTilerChromium::invalidateRect): |
+ (WebCore::LayerTilerChromium::prepareToUpdate): |
+ (WebCore::LayerTilerChromium::updateRect): |
+ (WebCore::LayerTilerChromium::draw): |
+ (WebCore::LayerTilerChromium::growLayerToContain): |
+ (WebCore::LayerTilerChromium::drawTiles): |
+ * platform/graphics/chromium/LayerTilerChromium.h: |
+ * platform/graphics/chromium/ShaderChromium.cpp: |
+ (WebCore::VertexShaderTile::VertexShaderTile): |
+ (WebCore::VertexShaderTile::init): |
+ (WebCore::VertexShaderTile::getShaderString): |
+ (WebCore::FragmentTexAlphaAABinding::FragmentTexAlphaAABinding): |
+ (WebCore::FragmentTexAlphaAABinding::init): |
+ (WebCore::FragmentShaderRGBATexAlphaAA::getShaderString): |
+ (WebCore::FragmentShaderRGBATexSwizzleAlphaAA::getShaderString): |
+ * platform/graphics/chromium/ShaderChromium.h: |
+ (WebCore::VertexShaderTile::vertexTexTransformLocation): |
+ (WebCore::FragmentTexAlphaAABinding::alphaLocation): |
+ (WebCore::FragmentTexAlphaAABinding::samplerLocation): |
+ (WebCore::FragmentTexAlphaAABinding::fragmentTexTransformLocation): |
+ (WebCore::FragmentTexAlphaAABinding::edgeLocation): |
+ * platform/graphics/chromium/TiledLayerChromium.cpp: |
+ (WebCore::TiledLayerChromium::TiledLayerChromium): |
+ (WebCore::TiledLayerChromium::updateTileSizeAndTilingOption): |
+ (WebCore::TiledLayerChromium::createTilerIfNeeded): |
+ (WebCore::TiledLayerChromium::setIsMask): |
+ * platform/graphics/chromium/TiledLayerChromium.h: |
+ * platform/graphics/gpu/TilingData.cpp: |
+ (WebCore::computeNumTiles): |
+ (WebCore::TilingData::tileXIndexFromSrcCoord): |
+ (WebCore::TilingData::tileYIndexFromSrcCoord): |
+ (WebCore::TilingData::tileSizeX): |
+ (WebCore::TilingData::tileSizeY): |
+ (WebCore::TilingData::intersectDrawQuad): |
+ (WebCore::TilingData::textureOffset): |
+ * platform/graphics/gpu/TilingData.h: |
+ |
+2011-08-01 David Levin <levin@chromium.org> |
+ |
+ Add asserts to RefCounted to make sure ref/deref happens on the right thread. |
+ https://bugs.webkit.org/show_bug.cgi?id=31639 |
+ |
+ Reviewed by Dmitry Titov. |
+ |
+ No new functionality exposed so no new tests. (The change is basically adding |
+ more testing.) |
+ |
+ * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added. |
+ * loader/icon/IconDatabase.cpp: |
+ (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable. |
+ (WebCore::IconDatabase::setIconDataForIconURL): Ditto. |
+ (WebCore::IconDatabase::getOrCreateIconRecord): Ditto. |
+ (WebCore::IconDatabase::readFromDatabase): Ditto. |
+ |
+2011-08-02 Luke Macpherson <macpherson@chromium.org> |
+ |
+ Clean up value clampling in CSSStyleSelector and CSSPrimitiveValue. |
+ https://bugs.webkit.org/show_bug.cgi?id=65441 |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ No new tests / refactoring only. |
+ |
+ * css/CSSPrimitiveValue.h: |
+ (WebCore::CSSPrimitiveValue::getFloatValue): |
+ Implement in terms of the new templated getValue(). |
+ (WebCore::CSSPrimitiveValue::getIntValue): |
+ Implement in terms of the new templated getValue(). |
+ (WebCore::CSSPrimitiveValue::getValue): |
+ Templated getValue that works for all numeric types. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ Use getValue<short> instead of rolling-your-own clamp to short. |
+ |
+2011-08-02 Julien Chaffraix <jchaffraix@webkit.org> |
+ |
+ RenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should be const |
+ https://bugs.webkit.org/show_bug.cgi?id=65494 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ No new tests, const-ness change only. |
+ |
+ * rendering/RenderObject.h: |
+ (WebCore::RenderObject::absoluteClippedOverflowRect): |
+ (WebCore::RenderObject::computeAbsoluteRepaintRect): |
+ Made those 2 const as they call a const method now. |
+ |
+ * rendering/RenderInline.cpp: |
+ (WebCore::RenderInline::clippedOverflowRectForRepaint): Use a const RenderObject* for iterating as |
+ this is const. |
+ |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::rectWithOutlineForRepaint): |
+ * rendering/RenderBlock.h: |
+ * rendering/RenderBox.cpp: |
+ (WebCore::RenderBox::clippedOverflowRectForRepaint): |
+ (WebCore::RenderBox::computeRectForRepaint): |
+ * rendering/RenderBox.h: |
+ * rendering/RenderInline.cpp: |
+ (WebCore::RenderInline::clippedOverflowRectForRepaint): |
+ (WebCore::RenderInline::rectWithOutlineForRepaint): |
+ (WebCore::RenderInline::computeRectForRepaint): |
+ * rendering/RenderInline.h: |
+ * rendering/RenderObject.cpp: |
+ (WebCore::RenderObject::rectWithOutlineForRepaint): |
+ (WebCore::RenderObject::clippedOverflowRectForRepaint): |
+ (WebCore::RenderObject::computeRectForRepaint): |
* rendering/RenderReplaced.cpp: |
- (WebCore::lengthIsSpecified): |
- (WebCore::RenderReplaced::computeReplacedLogicalWidth): |
- (WebCore::RenderReplaced::computeReplacedLogicalHeight): |
+ (WebCore::RenderReplaced::clippedOverflowRectForRepaint): |
+ * rendering/RenderReplaced.h: |
+ * rendering/RenderTableCell.cpp: |
+ (WebCore::RenderTableCell::clippedOverflowRectForRepaint): |
+ (WebCore::RenderTableCell::computeRectForRepaint): |
+ * rendering/RenderTableCell.h: |
+ * rendering/RenderTableCol.cpp: |
+ (WebCore::RenderTableCol::clippedOverflowRectForRepaint): |
+ * rendering/RenderTableCol.h: |
+ * rendering/RenderTableRow.cpp: |
+ (WebCore::RenderTableRow::clippedOverflowRectForRepaint): |
+ * rendering/RenderTableRow.h: |
+ * rendering/RenderText.cpp: |
+ (WebCore::RenderText::clippedOverflowRectForRepaint): |
+ * rendering/RenderText.h: |
+ * rendering/RenderView.cpp: |
+ (WebCore::RenderView::computeRectForRepaint): |
+ * rendering/RenderView.h: |
+ * rendering/svg/RenderSVGForeignObject.cpp: |
+ (WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint): |
+ (WebCore::RenderSVGForeignObject::computeRectForRepaint): |
+ * rendering/svg/RenderSVGForeignObject.h: |
+ * rendering/svg/RenderSVGGradientStop.h: |
+ (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint): |
+ * rendering/svg/RenderSVGHiddenContainer.h: |
+ (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint): |
+ * rendering/svg/RenderSVGInline.cpp: |
+ (WebCore::RenderSVGInline::clippedOverflowRectForRepaint): |
+ (WebCore::RenderSVGInline::computeRectForRepaint): |
+ * rendering/svg/RenderSVGInline.h: |
+ * rendering/svg/RenderSVGModelObject.cpp: |
+ (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint): |
+ (WebCore::RenderSVGModelObject::computeRectForRepaint): |
+ * rendering/svg/RenderSVGModelObject.h: |
* rendering/svg/RenderSVGRoot.cpp: |
- (WebCore::RenderSVGRoot::RenderSVGRoot): |
- (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): |
- (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): |
- (WebCore::RenderSVGRoot::layout): |
+ (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint): |
+ (WebCore::RenderSVGRoot::computeRectForRepaint): |
* rendering/svg/RenderSVGRoot.h: |
- * svg/SVGLength.cpp: |
- (WebCore::SVGLength::determineViewport): |
- * svg/SVGSVGElement.cpp: |
- (WebCore::SVGSVGElement::SVGSVGElement): |
- (WebCore::SVGSVGElement::currentScale): |
- (WebCore::SVGSVGElement::setCurrentScale): |
- (WebCore::SVGSVGElement::viewBoxToViewTransform): |
- * svg/SVGSVGElement.h: |
+ * rendering/svg/RenderSVGText.cpp: |
+ (WebCore::RenderSVGText::clippedOverflowRectForRepaint): |
+ (WebCore::RenderSVGText::computeRectForRepaint): |
+ * rendering/svg/RenderSVGText.h: |
+ * rendering/svg/SVGRenderSupport.cpp: |
+ (WebCore::SVGRenderSupport::clippedOverflowRectForRepaint): |
+ (WebCore::SVGRenderSupport::computeRectForRepaint): |
+ * rendering/svg/SVGRenderSupport.h: |
+ Updated the following method's signature to use a const object. |
+2011-08-02 Jeffrey Pfau <jpfau@apple.com> |
+ |
+ Add namespace prefix support in XML tokenizer |
+ https://bugs.webkit.org/show_bug.cgi?id=65578 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ This also changes markup debug printing to print to stderr instead of stdout |
+ |
+ * xml/parser/MarkupTokenBase.h: |
+ (WebCore::MarkupTokenBase::printString): |
+ * xml/parser/XMLToken.h: |
+ (WebCore::XMLToken::XMLDeclarationData::XMLDeclarationData): |
+ (WebCore::XMLToken::clear): |
+ (WebCore::XMLToken::appendToName): |
+ (WebCore::XMLToken::name): |
+ (WebCore::XMLToken::target): |
+ (WebCore::XMLToken::data): |
+ (WebCore::XMLToken::prefix): |
+ (WebCore::XMLToken::xmlDeclarationData): |
+ (WebCore::XMLToken::endPrefix): |
+ (WebCore::XMLToken::hasPrefix): |
+ (WebCore::XMLToken::endAttributePrefix): |
+ (WebCore::XMLToken::attributeHasPrefix): |
+ (WebCore::XMLToken::printAttrs): |
+ (WebCore::XMLToken::print): |
+ * xml/parser/XMLTokenizer.cpp: |
+ (WebCore::XMLTokenizer::nextToken): |
+ |
+2011-08-02 Zhenyao Mo <zmo@google.com> |
+ |
+ Unreviewed, rolling out r92238. |
+ http://trac.webkit.org/changeset/92238 |
+ https://bugs.webkit.org/show_bug.cgi?id=65555 |
+ |
+ fail fast/events/scrollbar-double-click.html on Mac |
+ |
+ * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: |
+ * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: |
+ * platform/chromium/ScrollbarThemeChromiumMac.h: |
+ * platform/chromium/ScrollbarThemeChromiumMac.mm: |
+ (WebCore::ScrollbarThemeChromiumMac::registerScrollbar): |
+ (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar): |
+ (WebCore::toScrollbarPainterKnobStyle): |
+ (WebCore::ScrollbarThemeChromiumMac::paint): |
+ |
+2011-08-02 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Remove LegacyDefaultOptionalArguments flag from History.idl |
+ https://bugs.webkit.org/show_bug.cgi?id=65572 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ No new tests, all existing tests pass. |
+ |
+ * page/History.idl: |
+ |
+2011-08-02 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Remove LegacyDefaultOptionalArguments flag from WebKitAnimationList.idl |
+ https://bugs.webkit.org/show_bug.cgi?id=65571 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ No new tests, all existing tests pass. |
+ |
+ * page/WebKitAnimationList.idl: |
+ |
+2011-08-02 James Robinson <jamesr@chromium.org> |
+ |
+ [chromium] Decouple layer visibility calculations from render surfaces / computed draw transforms |
+ https://bugs.webkit.org/show_bug.cgi?id=58840 |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ This decouples the layer visibility related calculations from the LayerChromium and CCLayerImpl trees. This is |
+ done by making LayerRendererChromium's "calculate the world" function (renamed |
+ calculateDrawTransformsAndVisibility()) a templated, free function that can operate on either LayerChromium + |
+ RenderSurfaceChromium pairs or on CCLayerImpl + CCRenderSurface pairs and invoking it twice, once before |
+ painting and once before drawing. Before painting, these calculations are used to determine which layers are |
+ potentially visible and should be painted, which depends on the calculated opacity, render surface bounds, and |
+ draw transforms. Before drawing, these calculations are used to figure out everything needed to draw. |
+ |
+ RenderSurfaceChromium is now used just for visibility calculations when painting. CCRenderSurfaceChromium is |
+ responsible for actually drawing the render surfaces. |
+ |
+ This does mean that in the current implementation the second calculations are redundant, but in the future this |
+ won't be the case since the pre-draw time calculations might be influenced by animations or gestures. I've |
+ added some traces to try to monitor if this math is a significant amount of the per-frame computation. Note |
+ that layer sorting only happens on the CCLayerImpl tree and the layer sort algorithm is the most expensive part |
+ of the calculations currently. |
+ |
+ This removes all of the weak back/forward pointers between LayerChromium and CCLayerImpls, the trees are now |
+ truly decoupled. |
+ |
+ Covered by compositing/ tests. |
+ |
+ * WebCore.gypi: |
+ * platform/graphics/chromium/CanvasLayerChromium.cpp: |
+ (WebCore::CanvasLayerChromium::createCCLayerImpl): |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::LayerChromium): |
+ (WebCore::LayerChromium::~LayerChromium): |
+ (WebCore::LayerChromium::createCCLayerImpl): |
+ (WebCore::LayerChromium::createRenderSurface): |
+ (WebCore::LayerChromium::descendantsDrawsContent): |
+ * platform/graphics/chromium/LayerChromium.h: |
+ (WebCore::LayerChromium::setUsesLayerScissor): |
+ (WebCore::LayerChromium::usesLayerScissor): |
+ (WebCore::LayerChromium::clearRenderSurface): |
+ (WebCore::LayerChromium::renderSurface): |
+ (WebCore::LayerChromium::drawOpacity): |
+ (WebCore::LayerChromium::setDrawOpacity): |
+ (WebCore::LayerChromium::scissorRect): |
+ (WebCore::LayerChromium::setScissorRect): |
+ (WebCore::LayerChromium::targetRenderSurface): |
+ (WebCore::LayerChromium::setTargetRenderSurface): |
+ (WebCore::LayerChromium::drawTransform): |
+ (WebCore::LayerChromium::setDrawTransform): |
+ (WebCore::LayerChromium::drawableContentRect): |
+ (WebCore::LayerChromium::setDrawableContentRect): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::updateLayers): |
+ (WebCore::LayerRendererChromium::drawLayers): |
+ (WebCore::LayerRendererChromium::paintLayerContents): |
+ (WebCore::LayerRendererChromium::drawLayersInternal): |
+ (WebCore::LayerRendererChromium::updateCompositorResources): |
+ (WebCore::LayerRendererChromium::setCompositeOffscreen): |
+ (WebCore::LayerRendererChromium::getOffscreenLayerTexture): |
+ (WebCore::LayerRendererChromium::useRenderSurface): |
+ (WebCore::LayerRendererChromium::drawLayer): |
+ (WebCore::LayerRendererChromium::initializeSharedObjects): |
+ (WebCore::LayerRendererChromium::renderSurfaceProgram): |
+ (WebCore::LayerRendererChromium::renderSurfaceMaskProgram): |
+ (WebCore::LayerRendererChromium::dumpRenderSurfaces): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ * platform/graphics/chromium/PluginLayerChromium.cpp: |
+ (WebCore::PluginLayerChromium::createCCLayerImpl): |
+ * platform/graphics/chromium/RenderSurfaceChromium.cpp: |
+ (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): |
+ (WebCore::RenderSurfaceChromium::~RenderSurfaceChromium): |
+ * platform/graphics/chromium/RenderSurfaceChromium.h: |
+ (WebCore::RenderSurfaceChromium::clearLayerList): |
+ (WebCore::RenderSurfaceChromium::layerList): |
+ (WebCore::RenderSurfaceChromium::setMaskLayer): |
+ * platform/graphics/chromium/TiledLayerChromium.cpp: |
+ (WebCore::TiledLayerChromium::createCCLayerImpl): |
+ (WebCore::TiledLayerChromium::tilingTransform): |
+ * platform/graphics/chromium/TreeSynchronizer.cpp: |
+ (WebCore::TreeSynchronizer::synchronizeTreeRecursive): |
+ * platform/graphics/chromium/VideoLayerChromium.cpp: |
+ (WebCore::VideoLayerChromium::createCCLayerImpl): |
+ * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: |
+ (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl): |
+ * platform/graphics/chromium/cc/CCCanvasLayerImpl.h: |
+ (WebCore::CCCanvasLayerImpl::create): |
+ * platform/graphics/chromium/cc/CCLayerImpl.cpp: |
+ (WebCore::CCLayerImpl::CCLayerImpl): |
+ (WebCore::CCLayerImpl::~CCLayerImpl): |
+ (WebCore::CCLayerImpl::createRenderSurface): |
+ (WebCore::CCLayerImpl::bindContentsTexture): |
+ * platform/graphics/chromium/cc/CCLayerImpl.h: |
+ (WebCore::CCLayerImpl::create): |
+ (WebCore::CCLayerImpl::renderSurface): |
+ (WebCore::CCLayerImpl::targetRenderSurface): |
+ (WebCore::CCLayerImpl::setTargetRenderSurface): |
+ * platform/graphics/chromium/cc/CCLayerSorter.cpp: |
+ (WebCore::CCLayerSorter::createGraphNodes): |
+ * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: |
+ (WebCore::CCPluginLayerImpl::CCPluginLayerImpl): |
+ * platform/graphics/chromium/cc/CCPluginLayerImpl.h: |
+ (WebCore::CCPluginLayerImpl::create): |
+ * platform/graphics/chromium/cc/CCRenderSurface.cpp: Copied from Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.cpp. |
+ (WebCore::CCRenderSurface::CCRenderSurface): |
+ (WebCore::CCRenderSurface::~CCRenderSurface): |
+ (WebCore::CCRenderSurface::cleanupResources): |
+ (WebCore::CCRenderSurface::layerRenderer): |
+ (WebCore::CCRenderSurface::drawableContentRect): |
+ (WebCore::CCRenderSurface::prepareContentsTexture): |
+ (WebCore::CCRenderSurface::releaseContentsTexture): |
+ (WebCore::CCRenderSurface::drawSurface): |
+ (WebCore::CCRenderSurface::draw): |
+ (WebCore::CCRenderSurface::name): |
+ (WebCore::writeIndent): |
+ (WebCore::CCRenderSurface::dumpSurface): |
+ (WebCore::CCRenderSurface::owningLayerId): |
+ * platform/graphics/chromium/cc/CCRenderSurface.h: Copied from Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.h. |
+ (WebCore::CCRenderSurface::contentRectCenter): |
+ (WebCore::CCRenderSurface::drawOpacity): |
+ (WebCore::CCRenderSurface::setDrawOpacity): |
+ (WebCore::CCRenderSurface::setDrawTransform): |
+ (WebCore::CCRenderSurface::drawTransform): |
+ (WebCore::CCRenderSurface::setReplicaDrawTransform): |
+ (WebCore::CCRenderSurface::replicaDrawTransform): |
+ (WebCore::CCRenderSurface::setOriginTransform): |
+ (WebCore::CCRenderSurface::originTransform): |
+ (WebCore::CCRenderSurface::setScissorRect): |
+ (WebCore::CCRenderSurface::scissorRect): |
+ (WebCore::CCRenderSurface::setContentRect): |
+ (WebCore::CCRenderSurface::contentRect): |
+ (WebCore::CCRenderSurface::setSkipsDraw): |
+ (WebCore::CCRenderSurface::skipsDraw): |
+ (WebCore::CCRenderSurface::clearLayerList): |
+ (WebCore::CCRenderSurface::layerList): |
+ (WebCore::CCRenderSurface::setMaskLayer): |
+ (WebCore::CCRenderSurface::contentsTexture): |
+ * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: |
+ (WebCore::CCTiledLayerImpl::CCTiledLayerImpl): |
+ * platform/graphics/chromium/cc/CCTiledLayerImpl.h: |
+ (WebCore::CCTiledLayerImpl::create): |
+ * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: |
+ (WebCore::CCVideoLayerImpl::CCVideoLayerImpl): |
+ * platform/graphics/chromium/cc/CCVideoLayerImpl.h: |
+ (WebCore::CCVideoLayerImpl::create): |
+ |
+2011-08-02 Luke Macpherson <macpherson@chromium.org> |
+ |
+ Implement CSSPropertyWebkitTextCombine, CSSPropertyWebkitTextEmphasisPosition and CSSPropertyWebkitTextEmphasisStyle in CSSStyleApplyProperty. |
+ https://bugs.webkit.org/show_bug.cgi?id=65517 |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ No new tests. Just refactoring and moving code around. |
+ |
+ * css/CSSStyleApplyProperty.cpp: |
+ Added class ApplyPropertyTextEmphasisStyle to handle the special TextEmphasisStyle logic. |
+ (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue): |
+ (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue): |
+ (WebCore::ApplyPropertyTextEmphasisStyle::applyValue): |
+ (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): |
+ Added initializations for CSSPropertyWebkitTextCombine, CSSPropertyWebkitTextEmphasisPosition, CSSPropertyWebkitTextEmphasisStyle. |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ Remove existing implementations. |
+ |
+2011-08-02 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Remove LegacyDefaultOptionalArguments flag from SpeechInputResultList.idl |
+ https://bugs.webkit.org/show_bug.cgi?id=65570 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ No new tests, all existing tests pass |
+ |
+ * page/SpeechInputResultList.idl: |
+ |
+2011-08-02 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Remove LegacyDefaultOptionalArguments flag from EventSource.idl |
+ https://bugs.webkit.org/show_bug.cgi?id=65568 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ No new tests, all existing tests pass. |
+ |
+ * page/EventSource.idl: |
+ |
+2011-08-02 Gavin Peters <gavinp@chromium.org> |
+ |
+ fail earlier to track down null CachedScript execution |
+ https://bugs.webkit.org/show_bug.cgi?id=65563 |
+ |
+ Over in http://code.google.com/p/chromium/issues/detail?id=75604 I can't reproduce the problem. Careful reading of the code hasn't led me |
+ to an obvious cause either. This patch should cause failure earlier, and lead to better stacks. I'll watch Chrome Canary's crash |
+ uploads carefully, and remove this CRASH() (and fix the underlying problem) once I understand it. |
+ |
+ Reviewed by Alexey Proskuryakov. |
+ |
+ No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce. |
+ |
+ * dom/ScriptRunner.cpp: |
+ (WebCore::ScriptRunner::queueScriptForExecution): |
+ |
+2011-08-02 Sailesh Agrawal <sail@chromium.org> |
+ |
+ Chromium: Update forked ScrollbarThemeChromiumMac.mm |
+ https://bugs.webkit.org/show_bug.cgi?id=65555 |
+ |
+ Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm. |
+ |
+ Reviewed by James Robinson. |
+ |
+ * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: |
+ * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: |
+ (wkScrollbarPainterSetEnabled): |
+ * platform/chromium/ScrollbarThemeChromiumMac.h: |
+ (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages): |
+ * platform/chromium/ScrollbarThemeChromiumMac.mm: |
+ (WebCore::ScrollbarThemeChromiumMac::registerScrollbar): |
+ (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar): |
+ (WebCore::toScrollbarPainterKnobStyle): |
+ (WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle): |
+ (WebCore::ScrollbarThemeChromiumMac::updateEnabledState): |
+ (WebCore::ScrollbarThemeChromiumMac::paint): |
+ |
+2011-08-02 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Remove LegacyDefaultOptionalArguments flag from SVG IDL files |
+ https://bugs.webkit.org/show_bug.cgi?id=65337 |
+ |
+ Reviewed by Nikolas Zimmermann. |
+ |
+ No new tests, all existing tests pass. |
+ |
+ * svg/ElementTimeControl.idl: |
+ * svg/SVGAnimationElement.idl: |
+ * svg/SVGDocument.idl: |
+ * svg/SVGElementInstance.idl: |
+ * svg/SVGElementInstanceList.idl: |
+ * svg/SVGException.idl: |
+ * svg/SVGFEDropShadowElement.idl: |
+ * svg/SVGFEGaussianBlurElement.idl: |
+ * svg/SVGFEMorphologyElement.idl: |
+ * svg/SVGFilterElement.idl: |
+ * svg/SVGLocatable.idl: |
+ * svg/SVGMarkerElement.idl: |
+ * svg/SVGPathElement.idl: |
+ * svg/SVGSVGElement.idl: |
+ * svg/SVGStylable.idl: |
+ * svg/SVGStyleElement.idl: |
+ * svg/SVGTests.idl: |
+ * svg/SVGTextContentElement.idl: |
+ |
+2011-08-02 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ Remove LegacyDefaultOptionalArguments flag from CSS IDL files |
+ https://bugs.webkit.org/show_bug.cgi?id=65341 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ No new tests. All existing tests pass. |
+ |
+ * css/CSSMediaRule.idl: |
+ * css/CSSPrimitiveValue.idl: |
+ * css/CSSRuleList.idl: |
+ * css/CSSStyleDeclaration.idl: |
+ * css/CSSStyleSheet.idl: |
+ * css/CSSValueList.idl: |
+ * css/MediaList.idl: |
+ * css/MediaQueryList.idl: |
+ * css/MediaQueryListListener.idl: |
+ * css/StyleMedia.idl: |
+ * css/StyleSheetList.idl: |
+ * css/WebKitCSSKeyframesRule.idl: |
+ * css/WebKitCSSMatrix.idl: |
+ |
+2011-08-02 Robert Kroeger <rjkroege@chromium.org> |
+ |
+ [chromium] Layering violations in gesture recognizer |
+ https://bugs.webkit.org/show_bug.cgi?id=65044 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Divided the gesture recognizer up to correct a layering |
+ violation by moving gesture implementation from it to |
+ EventHandler::handleGestureEvent so that the gesture recognizer |
+ could simply be an engine for generating gesture events from |
+ touch events. |
+ |
+ * dom/WheelEvent.cpp: |
+ (WebCore::WheelEvent::WheelEvent): |
+ (WebCore::WheelEvent::initWheelEvent): |
+ * dom/WheelEvent.h: |
+ Added symbolic contstant for tick multiplier. |
+ * page/EventHandler.cpp: |
+ (WebCore::EventHandler::EventHandler): |
+ Removed construction of gesture recognizer. |
+ (WebCore::EventHandler::handleGestureEvent): |
+ Extended for new gesture events added in this patch. |
+ (WebCore::EventHandler::handleTouchEvent): |
+ Removed call into gesture recognizer. |
+ * page/EventHandler.h: |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::reset): |
+ Removed code to reset gesture recognizer. |
+ * platform/PlatformGestureEvent.h: |
+ (WebCore::PlatformGestureEvent::PlatformGestureEvent): |
+ (WebCore::PlatformGestureEvent::deltaX): |
+ (WebCore::PlatformGestureEvent::deltaY): |
+ (WebCore::PlatformGestureEvent::shiftKey): |
+ (WebCore::PlatformGestureEvent::ctrlKey): |
+ (WebCore::PlatformGestureEvent::altKey): |
+ (WebCore::PlatformGestureEvent::metaKey): |
+ Added additional gesture types and parameters. |
+ * platform/PlatformGestureRecognizer.h: |
+ * platform/chromium/FramelessScrollView.h: |
+ Added support for displatching gesture and touch events. |
+ * platform/chromium/GestureRecognizerChromium.cpp: |
+ (WebCore::InnerGestureRecognizer::InnerGestureRecognizer): |
+ (WebCore::InnerGestureRecognizer::reset): |
+ (WebCore::InnerGestureRecognizer::constructClickGestureEvent): |
+ (WebCore::InnerGestureRecognizer::processTouchEventForGestures): |
+ Removed all depedencies on EventHandler. Instead, create gesture |
+ events from touch event stream. |
+ (WebCore::InnerGestureRecognizer::constructScrollGesture): |
+ (WebCore::touchDown): |
+ (WebCore::noGesture): |
+ (WebCore::click): |
+ (WebCore::isClickOrScroll): |
+ (WebCore::inScroll): |
+ (WebCore::GestureRecognizerChromium::processTouchEventForGestures): |
+ (WebCore::GestureRecognizerChromium::reset): |
+ * platform/chromium/GestureRecognizerChromium.h: |
+ * platform/chromium/PopupMenuChromium.cpp: |
+ Added support to handle touch events and gesture events. |
+ (WebCore::PopupContainer::handleTouchEvent): |
+ (WebCore::PopupContainer::handleGestureEvent): |
+ (WebCore::PopupListBox::handleTouchEvent): |
+ (WebCore::PopupListBox::handleGestureEvent): |
+ * platform/chromium/PopupMenuChromium.h: |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::handleGestureEvent): |
+ Ignores the newly added gesture event types. |
+ |
+2011-08-01 Michael Saboff <msaboff@apple.com> |
+ |
+ Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors |
+ https://bugs.webkit.org/show_bug.cgi?id=65502 |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ Change the vm_copy in PurgeableBuffer::create to be a memcpy. The |
+ vm_copy causes the process to have additional references to the same |
+ memory region. These additional reference caused madvise(MADV_FREE_REUSABLE) |
+ to fail when it encountered such pages. |
+ |
+ No tests added this is a resource defect and not a functional issue. |
+ |
+ * platform/mac/PurgeableBufferMac.cpp: |
+ (WebCore::PurgeableBuffer::create): |
+ |
+2011-08-02 Stephen White <senorblanco@chromium.org> |
+ |
+ [Chromium] Remove an unnecessary readback during accelerated |
+ canvas-to-canvas draws. |
+ https://bugs.webkit.org/show_bug.cgi?id=65560 |
+ |
+ Reviewed by James Robinson. |
+ |
+ No new tests. (Printing has few tests, sadly.) |
+ |
+ * platform/graphics/skia/ImageBufferSkia.cpp: |
+ (WebCore::ImageBuffer::draw): |
+ Revert most of the changes to this file from |
+ http://trac.webkit.org/changeset/91870, except for the call which makes |
+ the source context current, so that the readPixels() still works. |
+ |
+ |
+2011-08-02 Filip Pizlo <fpizlo@apple.com> |
+ |
+ JSC GC is far too conservative about growing the heap size, particularly |
+ on desktop platforms |
+ https://bugs.webkit.org/show_bug.cgi?id=65438 |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ No change in behavior, thus no new tests. |
+ |
+ Pass the LargeHeap hint to JSGlobalData when creating the JSC runtime |
+ instance corresponding to non-worker JS code. |
+ |
+ * bindings/js/JSDOMWindowBase.cpp: |
+ (WebCore::JSDOMWindowBase::commonJSGlobalData): |
+ |
+2011-08-02 Van Lam <vanlam@google.com> |
+ |
+ --webkit-visual-word: ctrl-arrow is not able to reach the boundary of line |
+ https://bugs.webkit.org/show_bug.cgi?id=61346 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ When collecintg word boundaries in a box, explicitly check if the box |
+ is at the end of line (so it should contain the end-of-line position) |
+ and collect the end-of-line position. |
+ |
+ * editing/visible_units.cpp: |
+ (WebCore::isBoxVisuallyLastInLine): |
+ (WebCore::appendPositionAtLogicalEndOfLine): |
+ (WebCore::collectWordBreaksInBoxInsideBlockWithSameDirectionality): |
+ (WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality): |
+ |
+2011-08-02 Vsevolod Vlasov <vsevik@chromium.org> |
+ |
+ Web Inspector: Should save scroll positions for network panel Response and Preview tabs. |
+ https://bugs.webkit.org/show_bug.cgi?id=65557 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * inspector/front-end/NetworkItemView.js: |
+ (WebInspector.ResourceContentView.prototype.get innerView): |
+ (WebInspector.ResourceContentView.prototype.set innerView): |
+ (WebInspector.ResourceContentView.prototype.hide): |
+ * inspector/front-end/ResourcePreviewView.js: |
+ (WebInspector.ResourcePreviewView.prototype.contentLoaded): |
+ * inspector/front-end/ResourceResponseView.js: |
+ (WebInspector.ResourceResponseView.prototype.contentLoaded): |
+ |
+2011-08-02 Vsevolod Vlasov <vsevik@chromium.org> |
+ |
+ Web Inspector: Remove initator column for JSC, fix network resource initiator tests. |
+ https://bugs.webkit.org/show_bug.cgi?id=65534 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * inspector/front-end/NetworkPanel.js: |
+ (WebInspector.NetworkLogView.prototype._createTable): |
+ (WebInspector.NetworkLogView.prototype.switchToDetailedView): |
+ (WebInspector.NetworkLogView.prototype.switchToBriefView): |
+ (WebInspector.NetworkLogView.prototype._toggleGridMode): |
+ (WebInspector.NetworkLogView.prototype._toggleViewingResourceMode): |
+ (WebInspector.NetworkDataGridNode.prototype.createCells): |
+ (WebInspector.NetworkDataGridNode.prototype.refreshResource): |
+ * inspector/front-end/Settings.js: |
+ |
+2011-08-02 Vsevolod Vlasov <vsevik@chromium.org> |
+ |
+ Web Inspector: SourceFrame should store saved scroll positions in View. |
+ https://bugs.webkit.org/show_bug.cgi?id=65472 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView): |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._sourceFileChanged): |
+ * inspector/front-end/SourceFrame.js: |
+ (WebInspector.SourceFrame.prototype.show): |
+ (WebInspector.SourceFrame.prototype.hide): |
+ (WebInspector.SourceFrame.prototype.get scrollLeft): |
+ (WebInspector.SourceFrame.prototype.set scrollLeft): |
+ (WebInspector.SourceFrame.prototype.get scrollTop): |
+ (WebInspector.SourceFrame.prototype.set scrollTop): |
+ * inspector/front-end/View.js: |
+ (WebInspector.View.prototype._innerShow): |
+ (WebInspector.View.prototype._innerHide): |
+ (WebInspector.View.prototype.detach): |
+ (WebInspector.View.prototype.storeScrollPositions): |
+ (WebInspector.View.prototype.inheritScrollPositionsFromView): |
+ (WebInspector.View.prototype.restoreScrollPositions): |
+ |
+2011-08-02 Jeff Miller <jeffm@apple.com> |
+ |
+ Move WTF_USE_AVFOUNDATION from JavaScriptCore/wtf/platform.h to WebCore/config.h |
+ https://bugs.webkit.org/show_bug.cgi?id=65552 |
+ |
+ Since this is a WebCore feature, there's no need to define it in JavaScriptCore/wtf/platform.h. |
+ |
+ Reviewed by Adam Roben. |
+ |
+ No change in functionality, so new tests. |
+ |
+ * config.h: Added WTF_USE_AVFOUNDATION. |
+ |
+2011-08-02 Alexandru Chiculita <achicu@adobe.com> |
+ |
+ Split RenderBlock::layoutRunsAndFloats into multiple methods |
+ https://bugs.webkit.org/show_bug.cgi?id=65376 |
+ |
+ Extracted layoutRunsAndFloatsInRange, linkToEndLineIfNeeded and repaintDirtyFloats methods and moved |
+ most of the locals to LineLayoutState. |
+ |
+ Reviewed by David Hyatt. |
+ |
+ No new tests needed because it is just refactoring existing code. |
+ |
+ * rendering/RenderBlock.h: |
+ * rendering/RenderBlockLineLayout.cpp: |
+ (WebCore::LineLayoutState::LineLayoutState): |
+ (WebCore::LineLayoutState::endLineMatched): |
+ (WebCore::LineLayoutState::setEndLineMatched): |
+ (WebCore::LineLayoutState::checkForFloatsFromLastLine): |
+ (WebCore::LineLayoutState::setCheckForFloatsFromLastLine): |
+ (WebCore::LineLayoutState::lineInfo): |
+ (WebCore::LineLayoutState::endLineLogicalTop): |
+ (WebCore::LineLayoutState::setEndLineLogicalTop): |
+ (WebCore::LineLayoutState::endLine): |
+ (WebCore::LineLayoutState::setEndLine): |
+ (WebCore::LineLayoutState::lastFloat): |
+ (WebCore::LineLayoutState::setLastFloat): |
+ (WebCore::LineLayoutState::floats): |
+ (WebCore::LineLayoutState::floatIndex): |
+ (WebCore::LineLayoutState::setFloatIndex): |
+ (WebCore::RenderBlock::layoutRunsAndFloats): |
+ (WebCore::RenderBlock::layoutRunsAndFloatsInRange): |
+ (WebCore::RenderBlock::linkToEndLineIfNeeded): |
+ (WebCore::RenderBlock::repaintDirtyFloats): |
+ (WebCore::RenderBlock::layoutInlineChildren): |
+ (WebCore::RenderBlock::determineStartPosition): |
+ (WebCore::RenderBlock::determineEndPosition): |
+ (WebCore::RenderBlock::matchedEndLine): |
+ |
+2011-08-02 Nat Duca <nduca@chromium.org> |
+ |
+ [chromium] Remove resizeOnscreenContent from LRC. It can be derived. |
+ https://bugs.webkit.org/show_bug.cgi?id=65519 |
+ |
+ Reviewed by James Robinson. |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::setViewport): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ |
+2011-08-02 Nico Weber <thakis@chromium.org> |
+ |
+ [chromium] Fix unresolved symbols error when linking to libwebkit.dylib |
+ https://bugs.webkit.org/show_bug.cgi?id=65498 |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ * WebCore.gyp/mac/adjust_visibility.sh: |
+ |
+2011-08-02 Mihnea Ovidenie <mihnea@adobe.com> |
+ |
+ hover then un-hover makes state change |
+ https://bugs.webkit.org/show_bug.cgi?id=56401 |
+ |
+ Reviewed by David Hyatt. |
+ |
+ When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous |
+ block with inline children. If it is, then we should change the insertion point to the first child of the |
+ anonymous block, otherwise the 'before' pseudo-element ends up in a different block. We choose the insertion |
+ point to be the first child only if the anonymous block has children, otherwise the before element ends up |
+ in a wrong block. |
+ |
+ Tests: fast/dynamic/hover-before-position-after-style-change.html |
+ fast/dynamic/hover-before-position-after-style-change2.html |
+ |
+ * rendering/RenderObjectChildList.cpp: |
+ (WebCore::RenderObjectChildList::updateBeforeAfterContent): |
+ |
+2011-08-02 Andreas Kling <kling@webkit.org> |
+ |
+ [Qt] Simplify Path::translate() implementation. |
+ https://bugs.webkit.org/show_bug.cgi?id=65540 |
+ |
+ Reviewed by Benjamin Poulain. |
+ |
+ * platform/graphics/qt/PathQt.cpp: |
+ (WebCore::Path::translate): |
+ |
+2011-07-30 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Web Inspector: merge FormattedSourceFile into SourceFile. |
+ https://bugs.webkit.org/show_bug.cgi?id=65411 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Prepare for splitting SourceFile into RawSourceCode and UISourceCode: |
+ * merge FormattedSourceFile into SourceFile |
+ * rename SourceFile to RawSourceCode |
+ * hide formatter worker lazy creation in ScriptFormatter |
+ |
+ * inspector/front-end/DebuggerPresentationModel.js: |
+ (WebInspector.DebuggerPresentationModel): |
+ (WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation): |
+ (WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation): |
+ (WebInspector.DebuggerPresentationModel.prototype._addScript): |
+ * inspector/front-end/ScriptFormatter.js: |
+ (WebInspector.ScriptFormatter): |
+ (WebInspector.ScriptFormatter.prototype._didFormatContent): |
+ (WebInspector.ScriptFormatter.prototype.get _worker): |
+ * inspector/front-end/SourceFile.js: |
+ (WebInspector.RawSourceCode): |
+ (WebInspector.RawSourceCode.prototype.setFormatted): |
+ (WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.didRequestContent): |
+ (WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded): |
+ (WebInspector.RawSourceCode.prototype._didRequestContent.didFormatContent): |
+ (WebInspector.RawSourceCode.prototype._didRequestContent): |
+ (WebInspector.RawSourceCode.prototype._invokeRequestContentCallbacks): |
+ |
+2011-08-02 Mihnea Ovidenie <mihnea@adobe.com> |
+ |
+ [CSSRegions]Fix build after changeset 92106 |
+ https://bugs.webkit.org/show_bug.cgi?id=65539 |
+ |
+ Reviewed by Adam Roben. |
+ |
+ No new tests since it is just a build fix. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ |
+2011-08-01 Vsevolod Vlasov <vsevik@chromium.org> |
+ |
+ Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors. |
+ https://bugs.webkit.org/show_bug.cgi?id=65466 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Test: http/tests/inspector/network/network-initiator-from-console.html |
+ |
+ * inspector/front-end/NetworkPanel.js: |
+ (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell): |
+ |
+2011-08-02 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ Web Inspector: img[width=90] or align attributes shouldnt be shown above element.style block (as they have lower specificity) |
+ https://bugs.webkit.org/show_bug.cgi?id=65514 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * inspector/front-end/StylesSidebarPane.js: |
+ |
+2011-08-02 Gyuyoung Kim <gyuyoung.kim@samsung.com> |
+ |
+ [EFL] Add fullscreen button to media control UI. |
+ https://bugs.webkit.org/show_bug.cgi?id=64428 |
+ |
+ Implement paintMediaFullscreenButton and emit fullscreen signal. |
+ |
+ Reviewed by Antonio Gomes. |
+ |
+ * platform/efl/RenderThemeEfl.cpp: |
+ (WebCore::RenderThemeEfl::edjeGroupFromFormType): |
+ (WebCore::RenderThemeEfl::emitMediaButtonSignal): |
+ (WebCore::RenderThemeEfl::paintMediaFullscreenButton): |
+ * platform/efl/RenderThemeEfl.h: |
+ |
+2011-08-01 Andrey Kosyakov <caseq@chromium.org> |
+ |
+ Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken |
+ https://bugs.webkit.org/show_bug.cgi?id=65476 |
+ |
+ - fixed webInspector.inspectedWindow.reload(), brought tests back. |
+ - removed redundant setting of user agent in FrameLoader::loadResourceSynchronously() |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Test: http/tests/inspector/extensions-useragent.html |
+ |
+ * inspector/front-end/ExtensionServer.js: |
+ (WebInspector.ExtensionServer.prototype._onReload): |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::loadResourceSynchronously): |
+ |
+2011-08-02 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Not reviewed: fixing inspector tests. |
+ |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): |
+ |
+2011-08-02 Pavel Feldman <pfeldman@google.com> |
+ |
+ Not reviewed: one line inspector style change. |
+ |
+ * inspector/front-end/networkLogView.css: |
+ (.network-error-row, .network-error-row .network-cell-subtitle): |
+ |
+2011-08-02 Amruth Raj <amruthraj@motorola.com> |
+ |
+ Custom cursors cause the WebProcess to crash |
+ https://bugs.webkit.org/show_bug.cgi?id=64802 |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ * WebCore.exp.in: |
+ |
+2011-08-02 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: _normalizeEventTypes (via console's monitorEvents) doesnt handle all events like 'search' and other atypical ones. |
+ https://bugs.webkit.org/show_bug.cgi?id=65468 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ * inspector/InjectedScriptSource.js: |
+ |
+2011-08-02 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: 404/errors should get a RED visual treatment so easier to identify. |
+ https://bugs.webkit.org/show_bug.cgi?id=65471 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ * inspector/front-end/NetworkPanel.js: |
+ (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): |
+ * inspector/front-end/networkLogView.css: |
+ (.network-error-cell): |
+ |
+2011-08-02 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: arrow is a pain to click in console. Drive-by selection reset fix. |
+ https://bugs.webkit.org/show_bug.cgi?id=65467 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ * inspector/front-end/ConsoleView.js: |
+ (WebInspector.ConsoleView.prototype._messagesClicked): |
+ * inspector/front-end/ObjectPropertiesSection.js: |
+ (WebInspector.ObjectPropertyTreeElement): |
+ * inspector/front-end/inspector.css: |
+ (.properties-tree li): |
+ (.properties-tree li.parent::before): |
+ * inspector/front-end/treeoutline.js: |
+ (TreeElement.treeElementToggled): |
+ |
+2011-08-01 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: button + "New style rule" |
+ https://bugs.webkit.org/show_bug.cgi?id=65409 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Test: inspector/styles/styles-add-new-rule.html |
+ |
+ * inspector/front-end/StylesSidebarPane.js: |
+ (WebInspector.StylesSidebarPane): |
+ (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): |
+ |
+2011-08-01 Luke Macpherson <macpherson@chromium.org> |
+ |
+ Don't set m_fontDirty when setting zoom unless zoom has actually changed |
+ https://bugs.webkit.org/show_bug.cgi?id=65092 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ No new tests as no functionality changed - this is an optimization that |
+ should be logically equivalent to the current code. |
+ |
+ The intent here is to avoid setting m_fontDirty unless the fornt information is actually dirty. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::styleForDocument): |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ Use setZoom and setEffectiveZoom wrapper functions. |
+ * css/CSSStyleSelector.h: |
+ (WebCore::CSSStyleSelector::setZoom): |
+ Wrapper for m_style->setZoom() that automatically updates m_fontDirty. |
+ (WebCore::CSSStyleSelector::setEffectiveZoom): |
+ Wrapper for m_style->setEffectiveZoom that automatically updates m_fontDirty. |
+ * page/animation/AnimationBase.cpp: |
+ (WebCore::AnimationBase::ensurePropertyMap): |
+ Use |
+ * rendering/style/RenderStyle.h: |
+ (WebCore::InheritedFlags::setZoom): |
+ Return true only if underlying values change. |
+ (WebCore::InheritedFlags::setZoomWithoutReturnValue): |
+ Return void to match function pointer type where required. |
+ (WebCore::InheritedFlags::setEffectiveZoom): |
+ Return true only if underlying values change. |
+ |
+2011-08-01 Jean-luc Brouillet <jeanluc@chromium.org> |
+ |
+ Removing old source files in gyp files that slow build |
+ https://bugs.webkit.org/show_bug.cgi?id=65503 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ A number of stale files are listed in the gyp files. These slow the |
+ build on Visual Studio 2010. Removing them. |
+ |
+ * WebCore.gypi: |
+ |
+2011-08-01 Bradley Nelson <bradnelson@chromium.org> |
+ |
+ Shard webcore_remaining for msvs official builds |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=65475 |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ webcore_remaining has consistently exceeded Visual Studio 2008's |
+ capacity to link when link time code generation is turned on (full |
+ release builds). This has been dealt with the past by carving off |
+ larger and larger pieces of webcore_remaining (ie webcore_html, |
+ webcore_renderer etc). |
+ A new option has been added to gyp to automate this sharding: |
+ 'msvs_shard': SHARD_COUNT, |
+ Targets marked in this way will be built in several pieces |
+ (target_0, target_1...). |
+ Since the resulting project is less comprehensible in the IDE (and |
+ since the linking limitation only afflicts official builds), this |
+ option is only needed for those builds. |
+ This patch shards webcore_remaining into 10 parts for official builds. |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ |
+2011-08-01 Alice Boxhall <aboxhall@chromium.org> |
+ |
+ WAI-ARIA textbox role should be AXTextArea for aria-multiline=true, AXTextField for aria-multiline=false |
+ https://bugs.webkit.org/show_bug.cgi?id=65451 |
+ |
+ Reviewed by Chris Fleizach. |
+ |
+ * accessibility/AccessibilityRenderObject.cpp: |
+ (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute): |
+ |
+2011-08-01 srikumar bonda <srikumar.b@gmail.com> |
+ |
+ Use threadsafeCopy() API when using Database Directory path variable |
+ https://bugs.webkit.org/show_bug.cgi?id=65436 |
+ |
+ Reviewed by David Levin. |
+ |
+ Use threadsafeCopy() API while using m_databaseDirectoryPath string variable |
+ when the databaseGuard lock hasn't been taken in DatabaseTracker class. |
+ This is just a safety fix. |
+ |
+ No changes to functionality so no new tests. |
+ |
+ * storage/DatabaseTracker.cpp: |
+ (WebCore::DatabaseTracker::trackerDatabasePath): |
+ (WebCore::DatabaseTracker::deleteOrigin): |
+ |
+2011-08-01 Michael Nordman <michaeln@google.com> |
+ |
+ [Chromium] WebSQLDatabase version handling is broken in multi-process browsers. |
+ https://bugs.webkit.org/show_bug.cgi?id=65486 |
+ |
+ The WebCore::AbstractDatabase class maintains a global in-memory map of |
+ the version numbers associated with open database files, but that map is |
+ not reliable in a multi-process system like Chrome. So instead of relying |
+ on the cached values in that map, we read the value from the database (and |
+ update the cached value) where possible. There are two edge cases where that's |
+ not possible because the scriptable interface requires synchronous access |
+ to the version: the .version attribute getter and the .openDatabase() method. |
+ In those cases, we have no choice but to use the potentially stale cached value. |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ No new tests. Existing layout tests cover the version handling functionality. |
+ |
+ * storage/AbstractDatabase.cpp: |
+ (WebCore::AbstractDatabase::version): |
+ (WebCore::AbstractDatabase::performOpenAndVerify): |
+ (WebCore::AbstractDatabase::getVersionFromDatabase): |
+ (WebCore::AbstractDatabase::setVersionInDatabase): |
+ (WebCore::AbstractDatabase::setExpectedVersion): |
+ (WebCore::AbstractDatabase::getCachedVersion): |
+ (WebCore::AbstractDatabase::setCachedVersion): |
+ (WebCore::AbstractDatabase::getActualVersionForTransaction): |
+ * storage/AbstractDatabase.h: |
+ (WebCore::AbstractDatabase::expectedVersion): |
+ * storage/ChangeVersionWrapper.cpp: |
+ (WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight): |
+ * storage/ChangeVersionWrapper.h: |
+ * storage/Database.cpp: |
+ (WebCore::Database::openDatabase): |
+ * storage/DatabaseSync.cpp: |
+ (WebCore::DatabaseSync::openDatabaseSync): |
+ (WebCore::DatabaseSync::changeVersion): |
+ * storage/SQLTransaction.cpp: |
+ (WebCore::SQLTransaction::SQLTransaction): |
+ (WebCore::SQLTransaction::executeSQL): |
+ (WebCore::SQLTransaction::openTransactionAndPreflight): |
+ (WebCore::SQLTransaction::runCurrentStatement): |
+ (WebCore::SQLTransaction::postflightAndCommit): |
+ * storage/SQLTransaction.h: |
+ * storage/SQLTransactionSync.cpp: |
+ (WebCore::SQLTransactionSync::SQLTransactionSync): |
+ (WebCore::SQLTransactionSync::executeSQL): |
+ (WebCore::SQLTransactionSync::begin): |
+ * storage/SQLTransactionSync.h: |
+ |
+2011-08-01 Tim Horton <timothy_horton@apple.com> |
+ |
+ Severe shadow repaint issues with SVGText elements |
+ https://bugs.webkit.org/show_bug.cgi?id=63648 |
+ <rdar://problem/7632269> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Make SVG elements which inherit from RenderSVGBlock take text-shadow |
+ overflow into account when determining whether or not they should draw |
+ |
+ Test: svg/custom/repaint-shadow.svg |
+ |
+ * rendering/RenderBox.h: |
+ (WebCore::RenderBox::visualOverflowRect): |
+ * rendering/svg/RenderSVGBlock.cpp: |
+ (WebCore::RenderSVGBlock::visualOverflowRect): |
+ * rendering/svg/RenderSVGBlock.h: |
+ |
+2011-08-01 Zhenyao Mo <zmo@google.com> |
+ |
+ Unreviewed, rolling out r92022. |
+ http://trac.webkit.org/changeset/92022 |
+ https://bugs.webkit.org/show_bug.cgi?id=65203 |
+ |
+ try to see if this is causing a bunch of browser tests failues |
+ on win bots - will recommit if not |
+ |
+ * platform/graphics/chromium/FontChromiumWin.cpp: |
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter): |
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init): |
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): |
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): |
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter): |
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter): |
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): |
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc): |
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter): |
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter): |
+ (WebCore::drawGlyphsWin): |
+ (WebCore::Font::drawComplexText): |
+ * platform/graphics/chromium/UniscribeHelper.cpp: |
+ (WebCore::UniscribeHelper::draw): |
+ * platform/graphics/skia/PlatformContextSkia.cpp: |
+ (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed): |
+ * platform/graphics/skia/PlatformContextSkia.h: |
+ * platform/graphics/skia/SkiaFontWin.cpp: |
+ (WebCore::windowsCanHandleDrawTextShadow): |
+ (WebCore::windowsCanHandleTextDrawing): |
+ (WebCore::windowsCanHandleTextDrawingWithoutShadow): |
+ * platform/graphics/skia/SkiaFontWin.h: |
+ |
2011-08-01 Scott Graham <scottmg@chromium.org> |
REGRESSION (r39725?): Resources removed from document can not be freed |